From: Florian Fainelli <f.fainelli@gmail.com>
To: netdev@vger.kernel.org
Cc: davem@davemloft.net, jaedon.shin@gmail.com, pgynther@google.com
Subject: Re: [PATCH net-next 2/2] net: bcmgenet: Implement RX coalescing control knobs
Date: Thu, 17 Sep 2015 11:18:45 -0700 [thread overview]
Message-ID: <55FB0405.8010503@gmail.com> (raw)
In-Reply-To: <55FAFF46.7010203@gmail.com>
On 17/09/15 10:58, Florian Fainelli wrote:
> On 16/09/15 16:47, Florian Fainelli wrote:
>> Add support for the ethtool rx-frames coalescing parameter which allows
>> defining the number of RX interrupts per frames received. The RDMA
>> engine supports a configurable timeout with a resolution of
>> approximately 8.192 us.
>>
>> We can no longer enable the BDONE/PDONE interrupts as those would
>> fire for each packet/buffer received, which would defeat the MBDONE
>> interrupt purpose. The MBDONE interrupt is guaranteed to correspond to a
>> PDONE/BDONE interrupt when the threshold is set to 1.
>
> *sigh*, I missed the initialization of the INTR_THRESHOLD register, so
> right now, we just have no interrupts configured properly for RX, will
> re-submit shortly.
>
> Meanwhile, please send feedback if you have any, thanks!
>
Actually, no that version of the patch is just fine, since we already
programmed the DMA_MBUF_DONE_THRESH since commit
6f5a272c99108d9f8450c454a4baede9e7cc643f (" net: bcmgenet: rework Rx
queue init")
Sorry about the noise, -ENOCOFFEE.
--
Florian
next prev parent reply other threads:[~2015-09-17 18:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-16 23:47 [PATCH net-next 0/2] net: bcmgenet: Interrupt coalescing Florian Fainelli
2015-09-16 23:47 ` [PATCH net-next 1/2] net: bcmgenet: Implement TX coalescing control knobs Florian Fainelli
2015-09-16 23:47 ` [PATCH net-next 2/2] net: bcmgenet: Implement RX " Florian Fainelli
2015-09-17 17:58 ` Florian Fainelli
2015-09-17 18:18 ` Florian Fainelli [this message]
2015-09-18 5:19 ` [PATCH net-next 0/2] net: bcmgenet: Interrupt coalescing David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55FB0405.8010503@gmail.com \
--to=f.fainelli@gmail.com \
--cc=davem@davemloft.net \
--cc=jaedon.shin@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pgynther@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.