Re: [Qemu-devel] [PATCH v11 02/12] init/cleanup of netfilter object

[Yang Hongyang <yanghy@cn.fujitsu.com>]

On 09/18/2015 12:09 AM, Eric Blake wrote:
> On 09/16/2015 07:23 PM, Yang Hongyang wrote:
>
>>>> +{ 'enum': 'NetFilterChain',
>>>> +  'data': [ 'all', 'in', 'out' ] }
>>>
>>> I don't see any other QMP usage of this enum anywhere in the series. Are
>>> you planning on supporting QMP?  If so, let's get that design discussion
>>> started.  If not, why not?
>>
>> This series is based on QOM, so the QMP command for object_add
>> will use this enum, for example:
>>    1 { "execute": "qmp_capabilities" }
>>    2 { "execute": "object-add",
>>    3              "arguments": { "qom-type": "filter-buffer",
>>    4                             "id": "f0",
>>    5                             "props": { "netdev": "bn0",
>>    6                                        "chain": "in",
>>    7                                        "interval": 2000 } } }
>>
>> for hmp:
>> object_add filter-buffer,id=f0,netdev=bn0,chain=in,interval=1000
>>
>> command options:
>> -object filter-buffer,id=f0,netdev=bn0,chain=in,interval=1000
>
> Do these examples appear in the documentation anywhere?  If not, it is
> worth considering (maybe under 'object-add' in qmp-commands.hx, for
> example).

Yes, example is added in the 9th patch, under qemu-options.hx.
Thank you.

>

-- 
Thanks,
Yang.