From mboxrd@z Thu Jan 1 00:00:00 1970 From: Caesar Wang Subject: Re: [PATCH 3/3] arm64: dts: rockchip: Add the needed timer for rk3368 SoC Date: Fri, 18 Sep 2015 09:16:53 +0800 Message-ID: <55FB6605.80601@gmail.com> References: <1442476272-31723-1-git-send-email-wxt@rock-chips.com> <1442476272-31723-4-git-send-email-wxt@rock-chips.com> <10188118.z6mI84Cd5Z@diego> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <10188118.z6mI84Cd5Z@diego> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: =?UTF-8?B?SGVpa28gU3TDvGJuZXI=?= Cc: Daniel Lezcano , Catalin Marinas , Will Deacon , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Kumar Gala , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Ian Campbell , linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Rob Herring , Pawel Moll , Mark Rutland , Olof Johansson , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: linux-rockchip.vger.kernel.org =E5=9C=A8 2015=E5=B9=B409=E6=9C=8818=E6=97=A5 03:01, Heiko St=C3=BCbner= =E5=86=99=E9=81=93: > Am Donnerstag, 17. September 2015, 15:51:12 schrieb Caesar Wang: >> There is a need of a broadcast timer in this case to ensure proper >> wakeup when the cpus are in sleep mode and a timer expires. >> >> Signed-off-by: Caesar Wang >> --- >> >> arch/arm64/boot/dts/rockchip/rk3368.dtsi | 6 ++++++ >> 1 file changed, 6 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/rockchip/rk3368.dtsi >> b/arch/arm64/boot/dts/rockchip/rk3368.dtsi index a712bea..99edbaa 10= 0644 >> --- a/arch/arm64/boot/dts/rockchip/rk3368.dtsi >> +++ b/arch/arm64/boot/dts/rockchip/rk3368.dtsi >> @@ -214,6 +214,12 @@ >> (GIC_CPU_MASK_SIMPLE(8) | IRQ_TYPE_LEVEL_HIGH)>; >> }; >> >> + timer@ff810000 { >> + compatible =3D "rockchip,rk3288-timer"; > you probably want a > compatible =3D "rockchip,rk3368-timer", "rockchip,rk3288-timer"; Done. More consideration for the future. Although the "rk3288-timer" is working for 3368, agreed to add the=20 'rk3368-timer' for the rk3368-spec timer in the future. > >> + reg =3D <0x0 0xff810000 0x0 0x20>; >> + interrupts =3D ; >> + }; >> + >> xin24m: oscillator { >> compatible =3D "fixed-clock"; >> clock-frequency =3D <24000000>; > > > > > --=20 > Thanks, > Caesar -- To unsubscribe from this list: send the line "unsubscribe devicetree" i= n the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: caesar.upstream@gmail.com (Caesar Wang) Date: Fri, 18 Sep 2015 09:16:53 +0800 Subject: [PATCH 3/3] arm64: dts: rockchip: Add the needed timer for rk3368 SoC In-Reply-To: <10188118.z6mI84Cd5Z@diego> References: <1442476272-31723-1-git-send-email-wxt@rock-chips.com> <1442476272-31723-4-git-send-email-wxt@rock-chips.com> <10188118.z6mI84Cd5Z@diego> Message-ID: <55FB6605.80601@gmail.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org ? 2015?09?18? 03:01, Heiko St?bner ??: > Am Donnerstag, 17. September 2015, 15:51:12 schrieb Caesar Wang: >> There is a need of a broadcast timer in this case to ensure proper >> wakeup when the cpus are in sleep mode and a timer expires. >> >> Signed-off-by: Caesar Wang >> --- >> >> arch/arm64/boot/dts/rockchip/rk3368.dtsi | 6 ++++++ >> 1 file changed, 6 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/rockchip/rk3368.dtsi >> b/arch/arm64/boot/dts/rockchip/rk3368.dtsi index a712bea..99edbaa 100644 >> --- a/arch/arm64/boot/dts/rockchip/rk3368.dtsi >> +++ b/arch/arm64/boot/dts/rockchip/rk3368.dtsi >> @@ -214,6 +214,12 @@ >> (GIC_CPU_MASK_SIMPLE(8) | IRQ_TYPE_LEVEL_HIGH)>; >> }; >> >> + timer at ff810000 { >> + compatible = "rockchip,rk3288-timer"; > you probably want a > compatible = "rockchip,rk3368-timer", "rockchip,rk3288-timer"; Done. More consideration for the future. Although the "rk3288-timer" is working for 3368, agreed to add the 'rk3368-timer' for the rk3368-spec timer in the future. > >> + reg = <0x0 0xff810000 0x0 0x20>; >> + interrupts = ; >> + }; >> + >> xin24m: oscillator { >> compatible = "fixed-clock"; >> clock-frequency = <24000000>; > > > > > -- > Thanks, > Caesar From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752864AbbIRBRN (ORCPT ); Thu, 17 Sep 2015 21:17:13 -0400 Received: from mail-pa0-f49.google.com ([209.85.220.49]:36614 "EHLO mail-pa0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752406AbbIRBRL (ORCPT ); Thu, 17 Sep 2015 21:17:11 -0400 Message-ID: <55FB6605.80601@gmail.com> Date: Fri, 18 Sep 2015 09:16:53 +0800 From: Caesar Wang User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: =?UTF-8?B?SGVpa28gU3TDvGJuZXI=?= CC: Daniel Lezcano , Catalin Marinas , Will Deacon , devicetree@vger.kernel.org, Kumar Gala , linux-kernel@vger.kernel.org, Ian Campbell , linux-rockchip@lists.infradead.org, Rob Herring , Pawel Moll , Mark Rutland , Olof Johansson , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 3/3] arm64: dts: rockchip: Add the needed timer for rk3368 SoC References: <1442476272-31723-1-git-send-email-wxt@rock-chips.com> <1442476272-31723-4-git-send-email-wxt@rock-chips.com> <10188118.z6mI84Cd5Z@diego> In-Reply-To: <10188118.z6mI84Cd5Z@diego> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 在 2015年09月18日 03:01, Heiko Stübner 写道: > Am Donnerstag, 17. September 2015, 15:51:12 schrieb Caesar Wang: >> There is a need of a broadcast timer in this case to ensure proper >> wakeup when the cpus are in sleep mode and a timer expires. >> >> Signed-off-by: Caesar Wang >> --- >> >> arch/arm64/boot/dts/rockchip/rk3368.dtsi | 6 ++++++ >> 1 file changed, 6 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/rockchip/rk3368.dtsi >> b/arch/arm64/boot/dts/rockchip/rk3368.dtsi index a712bea..99edbaa 100644 >> --- a/arch/arm64/boot/dts/rockchip/rk3368.dtsi >> +++ b/arch/arm64/boot/dts/rockchip/rk3368.dtsi >> @@ -214,6 +214,12 @@ >> (GIC_CPU_MASK_SIMPLE(8) | IRQ_TYPE_LEVEL_HIGH)>; >> }; >> >> + timer@ff810000 { >> + compatible = "rockchip,rk3288-timer"; > you probably want a > compatible = "rockchip,rk3368-timer", "rockchip,rk3288-timer"; Done. More consideration for the future. Although the "rk3288-timer" is working for 3368, agreed to add the 'rk3368-timer' for the rk3368-spec timer in the future. > >> + reg = <0x0 0xff810000 0x0 0x20>; >> + interrupts = ; >> + }; >> + >> xin24m: oscillator { >> compatible = "fixed-clock"; >> clock-frequency = <24000000>; > > > > > -- > Thanks, > Caesar