From: Eric Blake <eblake@redhat.com>
To: Wen Congyang <wency@cn.fujitsu.com>,
qemu devel <qemu-devel@nongnu.org>,
Markus Armbruster <armbru@redhat.com>,
Alberto Garcia <berto@igalia.com>,
Stefan Hajnoczi <stefanha@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>,
zhanghailiang <zhang.zhanghailiang@huawei.com>,
qemu block <qemu-block@nongnu.org>,
Jiang Yunhong <yunhong.jiang@intel.com>,
Dong Eddie <eddie.dong@intel.com>,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
Luiz Capitulino <lcapitulino@redhat.com>,
Gonglei <arei.gonglei@huawei.com>,
Yang Hongyang <yanghy@cn.fujitsu.com>
Subject: Re: [Qemu-devel] [PATCH v4 4/4] hmp: add monitor command to add/remove a child
Date: Fri, 18 Sep 2015 09:00:00 -0600 [thread overview]
Message-ID: <55FC26F0.5010507@redhat.com> (raw)
In-Reply-To: <1442571195-27116-5-git-send-email-wency@cn.fujitsu.com>
[-- Attachment #1: Type: text/plain, Size: 944 bytes --]
On 09/18/2015 04:13 AM, Wen Congyang wrote:
> Signed-off-by: Wen Congyang <wency@cn.fujitsu.com>
> Signed-off-by: zhanghailiang <zhang.zhanghailiang@huawei.com>
> Signed-off-by: Gonglei <arei.gonglei@huawei.com>
> Cc: Luiz Capitulino <lcapitulino@redhat.com>
> ---
> hmp-commands.hx | 28 ++++++++++++++++++++++++++++
> hmp.c | 20 ++++++++++++++++++++
> hmp.h | 2 ++
> 3 files changed, 50 insertions(+)
>
> +
> +STEXI
> +@item blockdev_child_add @var{parent device} @var{child device}
This produces poor-looking info that makes it appear that the command
takes 4 parameters, with two of those parameters both named 'device'.
I'd use just:
@item blockdev_child_add @var{parent} @var{child}
> +STEXI
> +@item blockdev_child_del @var{parent device} @var{child device}
Likewise.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
prev parent reply other threads:[~2015-09-18 15:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-18 10:13 [Qemu-devel] [PATCH v4 0/4] qapi: child add/delete support Wen Congyang
2015-09-18 10:13 ` [Qemu-devel] [PATCH v4 1/4] Add new block driver interface to add/delete a BDS's child Wen Congyang
2015-09-18 14:52 ` Eric Blake
2015-09-18 10:13 ` [Qemu-devel] [PATCH v4 2/4] quorum: implement bdrv_add_child() and bdrv_del_child() Wen Congyang
2015-09-18 10:13 ` [Qemu-devel] [PATCH v4 3/4] qmp: add monitor command to add/remove a child Wen Congyang
2015-09-18 14:58 ` Eric Blake
2015-09-18 10:13 ` [Qemu-devel] [PATCH v4 4/4] hmp: " Wen Congyang
2015-09-18 15:00 ` Eric Blake [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55FC26F0.5010507@redhat.com \
--to=eblake@redhat.com \
--cc=arei.gonglei@huawei.com \
--cc=armbru@redhat.com \
--cc=berto@igalia.com \
--cc=dgilbert@redhat.com \
--cc=eddie.dong@intel.com \
--cc=kwolf@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=wency@cn.fujitsu.com \
--cc=yanghy@cn.fujitsu.com \
--cc=yunhong.jiang@intel.com \
--cc=zhang.zhanghailiang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.