On 09/18/2015 04:59 AM, marcandre.lureau@redhat.com wrote: > From: Marc-André Lureau > > While reading the function I decided to write some tests. > > Signed-off-by: Marc-André Lureau > Reviewed-by: Eric Blake > --- > tests/test-cutils.c | 91 +++++++++++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 91 insertions(+) I accepted v1 because it was better than no tests at all, but did make some suggestions for additional tests to perform. I'm surprised you didn't include any of those suggestions in v2. For example, it would be nice if the testsuite documents a contract on what happens with a bogus suffix: is "1234x" outright rejected, or does it parse as "1234" leaving the pointer at 'x'? -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org