Re: [Qemu-devel] [PATCH 1/4] hmp-commands-info: move info_cmds content out of monitor.c

[Paolo Bonzini <pbonzini@redhat.com>]

On 18/09/2015 17:12, Markus Armbruster wrote:
> "Denis V. Lunev" <den@openvz.org> writes:
> 
>> From: Pavel Butsykin <pbutsykin@virtuozzo.com>
>>
>> For moving target- and device-specific code  from monitor.c,
>> to beginning we move info_cmds content to hmp-commands-info.hx
>>
>> Signed-off-by: Pavel Butsykin <pbutsykin@virtuozzo.com>
>> Signed-off-by: Denis V. Lunev <den@openvz.org>
>> CC: Paolo Bonzini <pbonzini@redhat.com>
>> CC: Peter Maydell <peter.maydell@linaro.org>
> 
> For me, this commit drops "info pci".
> 
> Before:
> 
>     $ qemu-system-x86_64 -nodefaults -S -display none -monitor stdio
>     QEMU 2.4.50 monitor - type 'help' for more information
>     (qemu) info pci
>       Bus  0, device   0, function 0:
>         Host bridge: PCI device 8086:1237
>           id ""
>       Bus  0, device   1, function 0:
>         ISA bridge: PCI device 8086:7000
>           id ""
>       Bus  0, device   1, function 1:
>         IDE controller: PCI device 8086:7010
>           BAR4: I/O at 0xffffffffffffffff [0x000e].
>           id ""
>       Bus  0, device   1, function 3:
>         Bridge: PCI device 8086:7113
>           IRQ 0.
>           id ""
> 
> After:
> 
>     (qemu) info pci
>     unknown command: 'pci'
> 
> Please advise.

s/advise/fix/...  patch sent.  Let me know who shall send it to Peter.

(BTW, it's obvious that I don't scale to 100+ patches per month.  Do you
still have that script of yours looking for unmaintained areas?).

Paolo