From: Max Reitz <mreitz@redhat.com>
To: Alberto Garcia <berto@igalia.com>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
qemu-block@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v5 2/4] block: support passing 'backing': '' to 'blockdev-add'
Date: Fri, 18 Sep 2015 17:41:42 +0200 [thread overview]
Message-ID: <55FC30B6.8060808@redhat.com> (raw)
In-Reply-To: <40dd21e6f39ce3c6412b6d568a85c3f226fa3bd2.1442581571.git.berto@igalia.com>
[-- Attachment #1: Type: text/plain, Size: 552 bytes --]
On 18.09.2015 15:16, Alberto Garcia wrote:
> Passing an empty string allows opening an image but not its backing
> file. This was already described in the API documentation, only the
> implementation was missing.
>
> This is useful for creating snapshots using images opened with
> blockdev-add, since they are not supposed to have a backing image
> before the operation.
>
> Signed-off-by: Alberto Garcia <berto@igalia.com>
> ---
> block.c | 7 +++++++
> 1 file changed, 7 insertions(+)
Reviewed-by: Max Reitz <mreitz@redhat.com>
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2015-09-18 15:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-18 13:16 [Qemu-devel] [PATCH v5 0/4] Add 'blockdev-snapshot' command Alberto Garcia
2015-09-18 13:16 ` [Qemu-devel] [PATCH v5 1/4] block: rename BlockdevSnapshot to BlockdevSnapshotSync Alberto Garcia
2015-09-18 13:16 ` [Qemu-devel] [PATCH v5 2/4] block: support passing 'backing': '' to 'blockdev-add' Alberto Garcia
2015-09-18 15:41 ` Max Reitz [this message]
2015-09-18 13:16 ` [Qemu-devel] [PATCH v5 3/4] block: add a 'blockdev-snapshot' QMP command Alberto Garcia
2015-09-18 13:16 ` [Qemu-devel] [PATCH v5 4/4] block: add tests for the 'blockdev-snapshot' command Alberto Garcia
2015-09-18 15:45 ` Max Reitz
2015-09-18 15:12 ` [Qemu-devel] [PATCH v5 0/4] Add " Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55FC30B6.8060808@redhat.com \
--to=mreitz@redhat.com \
--cc=berto@igalia.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.