Re: [PATCH V2] IB/hfi: Properly set permissions for user device files

[Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>]

[-- Attachment #1: Type: text/plain, Size: 1211 bytes --]

On 09/17/2015 01:47 PM, ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org wrote:
> From: Ira Weiny <ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> 
> Some of the device files are required to be user accessible for PSM while
> most should remain accessible only by root.
> 
> Add a parameter to hfi1_cdev_init which controls if the user should have access
> to this device which places it in a different class with the appropriate
> devnode callback.
> 
> In addition set the devnode call back for the existing class to be a bit more
> explicit for those permissions.
> 
> Finally remove the unnecessary null check before class_destroy
> 
> Tested-by: Donald Dutile <ddutile-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
> Signed-off-by: Haralanov, Mitko (mitko.haralanov-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org)
> Signed-off-by: Ira Weiny <ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> 
> ---
> 
> Changes from V1:
> 	Fixed typo in error message
> 	added missing goto on error
> 	Remove null checks for class
> 	set user_class to NULL on error

Thanks, applied.


-- 
Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
              GPG KeyID: 0E572FDD



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 884 bytes --]