All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: Thomas Wood <thomas.wood@intel.com>
Cc: Intel Graphics Development <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH] tests/gem_ctx_param_basic: fix up non-root-set-no-zeromap subtest
Date: Fri, 18 Sep 2015 09:02:27 -0700	[thread overview]
Message-ID: <55FC3593.60502@virtuousgeek.org> (raw)
In-Reply-To: <CANkqdn0+Q2izEg8TOc5nYhOLGcf5K5UvzzSmnprj-wf0pHUVHA@mail.gmail.com>

On 09/18/2015 03:22 AM, Thomas Wood wrote:
> It's helpful to include "i-g-t" in the subject line for
> intel-gpu-tools patches so that they are easily identified. This can
> be done by using the --subject-prefix "PATCH i-g-t" option when using
> git format-patch or send-email and can also be set as a local
> configuration option using the following command: git config
> format.subjectprefix "PATCH i-g-t"

Yeah you mentioned this before and I forgot, sorry.  I'll add git configs to my igt repos so make it happen automatically.

> On 17 September 2015 at 17:41, Jesse Barnes <jbarnes@virtuousgeek.org> wrote:
>> This subtest is trying to set the no-zeromap flag on the context without
>> root privs.  Rather than expecting an EPERM on what's presumably a
>> nonzero value, we should expect success on a set call w/o root privs.
>> This looks like a copy & paste error from when the subtest was added,
>> since setting the ban period has different expected behavior.
> 
> There is already a patch for this: http://patchwork.freedesktop.org/patch/58991/
> 
> I was waiting for confirmation on the expected behaviour, but also
> testing both root and non-root for success seems a bit redundant.
> Perhaps removing the root-set test would be worthwhile.

Yeah that would be ok too.  FWIW the other patch has my r-b too, though I haven't heard back from David.

Do you want to commit Daniele's patch or should I just push mine?

Thanks,
Jesse

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2015-09-18 16:02 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-17 16:41 [PATCH] tests/gem_ctx_param_basic: fix up non-root-set-no-zeromap subtest Jesse Barnes
2015-09-18 10:22 ` Thomas Wood
2015-09-18 16:02   ` Jesse Barnes [this message]
2015-09-18 16:40     ` Thomas Wood

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55FC3593.60502@virtuousgeek.org \
    --to=jbarnes@virtuousgeek.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=thomas.wood@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.