From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [PATCH v8 03/13] KVM: Define a new interface kvm_intr_is_single_vcpu() Date: Fri, 18 Sep 2015 18:17:29 +0200 Message-ID: <55FC3919.9030204@redhat.com> References: <1442393409-2623-1-git-send-email-feng.wu@intel.com> <1442393409-2623-4-git-send-email-feng.wu@intel.com> <55F934F5.7040605@redhat.com> <55FA8AED.6090700@redhat.com> <55FACD35.1030602@redhat.com> <20150917155821.GB2573@potion.brq.redhat.com> <55FAE395.4000008@redhat.com> <20150918161631.GA27908@potion.brq.redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20150918161631.GA27908-KfRq7+sF/6zkZJWtSm8s3NvLeJWuRmrY@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= , "Wu, Feng" Cc: "kvm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "eric.auger-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org" , "mtosatti-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org" , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org" List-Id: iommu@lists.linux-foundation.org CgpPbiAxOC8wOS8yMDE1IDE4OjE2LCBSYWRpbSBLcsSNbcOhxZkgd3JvdGU6Cj4+PiA+PiBPaywg SSB3YXMgd29uZGVyaW5nIHdoZXRoZXIgdGhpcyB3YXMgdGhlIGNvcnJlY3QgaW50ZXJwcmV0YXRp b24uICBUaGFua3MhCj4+ID4gCj4+ID4gUGFvbG8sIEkgZG9uJ3QgdGhpbmsgUmFkaW0gY2xhcmlm eSB5b3VyIGNvbmNlcm4sIHJpZ2h0PyBTaW5jZSBtZGEgaXMgOC1iaXQsIGl0Cj4+ID4gaXMgd3Jv bmcgd2l0aCBtZGEgPj4gMTYsIHRoaXMgaXMgeW91ciBjb25jZXJuLCByaWdodD8KPiBJbiBjYXNl IGl0IHdhczogIG1kYSBpcyB1MzIgc28gdGhlIGJpdHNoaWZ0IGlzIGRlZmluZWQgYnkgQy4KPiAo eEFQSUMgZGVzdGluYXRpb25zIGluIEtWTSdzIHgyQVBJQyBtb2RlIGFyZSBzdG9yZWQgaW4gbG93 ZXN0IDggYml0cyBvZgo+ICBtZGEsIGhlbmNlIHRoZSBjbHVzdGVyIGlzIGFsd2F5cyAwLikKPiAK PiBPciBhbSBJIHN0aWxsIG1pc3NpbmcgdGhlIHBvaW50PwoKWWVzLCByZW1lbWJlcmluZyB0aGF0 IHRoZSBjbHVzdGVyIGlzIGFsd2F5cyAwIHNvbHZlZCBteSBkb3VidC4KClBhb2xvCl9fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmlvbW11IG1haWxpbmcgbGlz dAppb21tdUBsaXN0cy5saW51eC1mb3VuZGF0aW9uLm9yZwpodHRwczovL2xpc3RzLmxpbnV4Zm91 bmRhdGlvbi5vcmcvbWFpbG1hbi9saXN0aW5mby9pb21tdQ== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754368AbbIRQRi (ORCPT ); Fri, 18 Sep 2015 12:17:38 -0400 Received: from mx1.redhat.com ([209.132.183.28]:46930 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754292AbbIRQRe (ORCPT ); Fri, 18 Sep 2015 12:17:34 -0400 Subject: Re: [PATCH v8 03/13] KVM: Define a new interface kvm_intr_is_single_vcpu() To: =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= , "Wu, Feng" References: <1442393409-2623-1-git-send-email-feng.wu@intel.com> <1442393409-2623-4-git-send-email-feng.wu@intel.com> <55F934F5.7040605@redhat.com> <55FA8AED.6090700@redhat.com> <55FACD35.1030602@redhat.com> <20150917155821.GB2573@potion.brq.redhat.com> <55FAE395.4000008@redhat.com> <20150918161631.GA27908@potion.brq.redhat.com> Cc: "alex.williamson@redhat.com" , "joro@8bytes.org" , "mtosatti@redhat.com" , "eric.auger@linaro.org" , "kvm@vger.kernel.org" , "iommu@lists.linux-foundation.org" , "linux-kernel@vger.kernel.org" From: Paolo Bonzini Message-ID: <55FC3919.9030204@redhat.com> Date: Fri, 18 Sep 2015 18:17:29 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <20150918161631.GA27908@potion.brq.redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 18/09/2015 18:16, Radim Krčmář wrote: >>> >> Ok, I was wondering whether this was the correct interpretation. Thanks! >> > >> > Paolo, I don't think Radim clarify your concern, right? Since mda is 8-bit, it >> > is wrong with mda >> 16, this is your concern, right? > In case it was: mda is u32 so the bitshift is defined by C. > (xAPIC destinations in KVM's x2APIC mode are stored in lowest 8 bits of > mda, hence the cluster is always 0.) > > Or am I still missing the point? Yes, remembering that the cluster is always 0 solved my doubt. Paolo