From: Corey Minyard <minyard@acm.org>
To: Luis de Bethencourt <luis@debethencourt.com>,
linux-kernel@vger.kernel.org
Cc: openipmi-developer@lists.sourceforge.net
Subject: Re: [PATCH 2/2] char: ipmi: Fix module autoload for OF platform driver
Date: Fri, 18 Sep 2015 20:53:59 -0500 [thread overview]
Message-ID: <55FCC037.5080306@acm.org> (raw)
In-Reply-To: <20150915164206.GA5693@goodgumbo.baconseed.org>
This is there now in the main kernel, but it's further down. Perhaps it
should be moved.
-corey
On 09/15/2015 11:42 AM, Luis de Bethencourt wrote:
> This platform driver has a OF device ID table but the OF module
> alias information is not created so module autoloading won't work.
>
> Signed-off-by: Luis de Bethencourt <luisbg@osg.samsung.com>
> ---
> drivers/char/ipmi/ipmi_si_intf.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/char/ipmi/ipmi_si_intf.c b/drivers/char/ipmi/ipmi_si_intf.c
> index 967b73a..43e1fb24 100644
> --- a/drivers/char/ipmi/ipmi_si_intf.c
> +++ b/drivers/char/ipmi/ipmi_si_intf.c
> @@ -2784,6 +2784,7 @@ static struct of_device_id ipmi_match[] =
> .data = (void *)(unsigned long) SI_BT },
> {},
> };
> +MODULE_DEVICE_TABLE(of, ipmi_match);
>
> static struct platform_driver ipmi_driver = {
> .driver = {
prev parent reply other threads:[~2015-09-19 1:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-15 16:42 [PATCH 2/2] char: ipmi: Fix module autoload for OF platform driver Luis de Bethencourt
2015-09-19 1:53 ` Corey Minyard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55FCC037.5080306@acm.org \
--to=minyard@acm.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luis@debethencourt.com \
--cc=openipmi-developer@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.