From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753287AbbITAq1 (ORCPT ); Sat, 19 Sep 2015 20:46:27 -0400 Received: from mail-ob0-f182.google.com ([209.85.214.182]:34862 "EHLO mail-ob0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752107AbbITAq0 (ORCPT ); Sat, 19 Sep 2015 20:46:26 -0400 Message-ID: <55FE01E0.5040309@acm.org> Date: Sat, 19 Sep 2015 19:46:24 -0500 From: Corey Minyard Reply-To: minyard@acm.org User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-Version: 1.0 To: Luis de Bethencourt , linux-kernel@vger.kernel.org CC: openipmi-developer@lists.sourceforge.net Subject: Re: [PATCH] char: ipmi: Move MODULE_DEVICE_TABLE() to follow struct References: <1442677403-26738-1-git-send-email-luisbg@osg.samsung.com> In-Reply-To: <1442677403-26738-1-git-send-email-luisbg@osg.samsung.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Ok, queued for 4.4. Thanks, -corey On 09/19/2015 10:43 AM, Luis de Bethencourt wrote: > The policy for drivers is to have MODULE_DEVICE_TABLE() just after the > struct used in it. For clarity. > > Suggested-by: Corey Minyard > Signed-off-by: Luis de Bethencourt > --- > > Suggested in: > https://lkml.org/lkml/2015/9/18/842 > > Thanks Corey, > Luis > > drivers/char/ipmi/ipmi_si_intf.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/char/ipmi/ipmi_si_intf.c b/drivers/char/ipmi/ipmi_si_intf.c > index 654f6f3..061fef0 100644 > --- a/drivers/char/ipmi/ipmi_si_intf.c > +++ b/drivers/char/ipmi/ipmi_si_intf.c > @@ -2560,6 +2560,7 @@ static const struct of_device_id of_ipmi_match[] = { > .data = (void *)(unsigned long) SI_BT }, > {}, > }; > +MODULE_DEVICE_TABLE(of, of_ipmi_match); > > static int of_ipmi_probe(struct platform_device *dev) > { > @@ -2646,7 +2647,6 @@ static int of_ipmi_probe(struct platform_device *dev) > } > return 0; > } > -MODULE_DEVICE_TABLE(of, of_ipmi_match); > #else > #define of_ipmi_match NULL > static int of_ipmi_probe(struct platform_device *dev)