From: roopa <roopa@cumulusnetworks.com>
To: Scott Feldman <sfeldma@gmail.com>
Cc: Netdev <netdev@vger.kernel.org>, "Jiří Pírko" <jiri@resnulli.us>,
"Siva Mannem" <siva.mannem.lnx@gmail.com>,
"Premkumar Jonnala" <pjonnala@broadcom.com>,
"stephen@networkplumber.org" <stephen@networkplumber.org>,
"andrew@lunn.ch" <andrew@lunn.ch>,
"Florian Fainelli" <f.fainelli@gmail.com>,
"Vivien Didelot" <vivien.didelot@savoirfairelinux.com>,
"Wilson Kok" <wkok@cumulusnetworks.com>
Subject: Re: [PATCH net-next 7/7] switchdev: update documentation on FDB ageing_time
Date: Sun, 20 Sep 2015 07:24:31 -0700 [thread overview]
Message-ID: <55FEC19F.80601@cumulusnetworks.com> (raw)
In-Reply-To: <CAE4R7bD_FchEJ_HuuJcGx0_fqwjxCG_EsYETogVO6O-6uoLj1g@mail.gmail.com>
On 9/19/15, 7:21 PM, Scott Feldman wrote:
> Yes, your switch driver is in user-space so you have to use NTF_USE to
> refresh the entry since you cannot use the kernel driver model to
> call_switchdev_notifiers(SWITCHDEV_FDB_ADD, ...). Consequently, your
> entries are not marked with NTF_EXT_LEARNED, so this patch is a no-op
> for you. You can continue to use the bridge driver to age out your
> entries.
yes, correct. I was not really saying this because it will cause us any
problems.
I was trying to say this for switchdev in general.
> I'd rather someone add that knob when it's actually needed. When the
> first in-kernel switchdev driver that wants to use the bridge driver's
> ageing function, then we can make that adjustment.
I was suggesting the other way around. Keep the default to what is in
the kernel today and the first in-kernel switchdev driver that wants to age,
should introduce the ability to not age in the bridge driver (Rocker
will continue to work as it does today). Because, I am only concerned
that rocker may end up being the only device that uses the default
behavior introduced by this patch. And every real hardware uses the
bridge driver to age (because there are no in kernel examples today). I
am curious to know who else is using hardware ageing today.
next prev parent reply other threads:[~2015-09-20 14:24 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-18 19:55 [PATCH net-next 0/7] bridge: don't age out externally added FDB entries sfeldma
2015-09-18 19:55 ` [PATCH net-next 1/7] rocker: track when FDB entry is touched sfeldma
2015-09-19 6:31 ` Jiri Pirko
2015-09-18 19:55 ` [PATCH net-next 2/7] rocker: store rocker_port in fdb key rather than pport sfeldma
2015-09-19 6:31 ` Jiri Pirko
2015-09-18 19:55 ` [PATCH net-next 3/7] rocker: adding port ageing_time for ageing out FDB entries sfeldma
2015-09-19 6:30 ` Jiri Pirko
2015-09-19 17:16 ` Scott Feldman
2015-09-18 19:55 ` [PATCH net-next 4/7] bridge: define some min/max ageing time constants we'll use next sfeldma
2015-09-19 6:45 ` Jiri Pirko
2015-09-19 17:20 ` Scott Feldman
2015-09-22 8:28 ` Premkumar Jonnala
2015-09-18 19:55 ` [PATCH net-next 5/7] rocker: add FDB cleanup timer sfeldma
2015-09-19 6:56 ` Jiri Pirko
2015-09-18 19:55 ` [PATCH net-next 6/7] bridge: don't age externally added FDB entries sfeldma
2015-09-18 21:26 ` Vivien Didelot
2015-09-19 6:57 ` Jiri Pirko
2015-09-22 8:22 ` Premkumar Jonnala
2015-09-18 19:55 ` [PATCH net-next 7/7] switchdev: update documentation on FDB ageing_time sfeldma
2015-09-18 21:35 ` Vivien Didelot
2015-09-19 6:58 ` Jiri Pirko
2015-09-20 1:21 ` roopa
2015-09-20 2:21 ` Scott Feldman
2015-09-20 14:24 ` roopa [this message]
2015-09-20 15:56 ` Scott Feldman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55FEC19F.80601@cumulusnetworks.com \
--to=roopa@cumulusnetworks.com \
--cc=andrew@lunn.ch \
--cc=f.fainelli@gmail.com \
--cc=jiri@resnulli.us \
--cc=netdev@vger.kernel.org \
--cc=pjonnala@broadcom.com \
--cc=sfeldma@gmail.com \
--cc=siva.mannem.lnx@gmail.com \
--cc=stephen@networkplumber.org \
--cc=vivien.didelot@savoirfairelinux.com \
--cc=wkok@cumulusnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.