From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail.windriver.com ([147.11.1.11]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1Zdqle-0007SX-2c for kexec@lists.infradead.org; Mon, 21 Sep 2015 02:23:46 +0000 Message-ID: <55FF6A21.7030601@windriver.com> Date: Mon, 21 Sep 2015 10:23:29 +0800 From: yjin MIME-Version: 1.0 Subject: Re: [PATCH] mips: vmcore: forced convert 'hdr' in elf_check_arch() References: <1442562171-21307-1-git-send-email-yanjiang.jin@windriver.com> <1442562171-21307-2-git-send-email-yanjiang.jin@windriver.com> <55FF6876.7080908@windriver.com> In-Reply-To: <55FF6876.7080908@windriver.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "kexec" Errors-To: kexec-bounces+dwmw2=infradead.org@lists.infradead.org To: ralf@linux-mips.org Cc: linux-mips@linux-mips.org, mhuang@redhat.com, kexec@lists.infradead.org, jinyanjiang@gmail.com, linux-kernel@vger.kernel.org, akpm@linux-foundation.org, chaowang@redhat.com SXQgc2VlbXMgdGhlIGxhc3QgbWFpbCBoYXMgYmVlbiBibG9ja2VkLCByZXNlbmQgaXQuCgpPbiAy MDE15bm0MDnmnIgyMeaXpSAxMDoxNiwgeWppbiB3cm90ZToKPiBUaGUgbmV3IHZlcnNpb24gcGF0 Y2ggb25seSBtb2RpZmllcyBtaXBzL2VsZi5oLCBzbyBhZGQgUmFsZiBCYWVjaGxlIAo+IGFuZCBj YyBsaW51eC1taXBzQGxpbnV4LW1pcHMub3JnLgo+IFRoaXMgaXMgYSBWMiBwYXRjaCwgYXR0YWNo IHRoZSBWMSBwYXRjaCBmb3IgcmVmZXJlbmNlLgo+Cj4gVGhhbmtzIQo+IFlhbmppYW5nCj4KPiBP biAyMDE15bm0MDnmnIgxOOaXpSAxNTo0MiwgeWFuamlhbmcuamluQHdpbmRyaXZlci5jb20gd3Jv dGU6Cj4+IEZyb206IFlhbmppYW5nIEppbiA8eWFuamlhbmcuamluQHdpbmRyaXZlci5jb20+Cj4+ Cj4+IGVsZl9jaGVja19hcmNoKCkgd2lsbCBiZSBjYWxsZWQgYm90aCBpbiBwYXJzZV9jcmFzaF9l bGY2NF9oZWFkZXJzKCkKPj4gYW5kIHBhcnNlX2NyYXNoX2VsZjMyX2hlYWRlcnMoKS4gQnV0IGlu IHRoZXNlIHR3byBmdW5jdGlvbnMsIHRoZSB0eXBlIG9mCj4+IHRoZSBwYXJhbWV0ZXIgZWhkciBp cyBkaWZmZXJlbnQ6IEVsZjMyX0VoZHIgYW5kIEVsZjY0X0VoZHIuCj4+Cj4+IEZ1bmN0aW9uIHBh cnNlX2NyYXNoX2VsZl9oZWFkZXJzKCkgcmVhZHMgZV9pZGVudFtFSV9DTEFTU10gdGhlbiAKPj4g ZGVjaWRlcyB0bwo+PiBjYWxsIHBhcnNlX2NyYXNoX2VsZjY0X2hlYWRlcnMoKSBvciBwYXJzZV9j cmFzaF9lbGYzMl9oZWFkZXJzKCkuCj4+IFRoaXMgaGFwcGVucyBpbiBydW4gdGltZSwgbm90IGNv bXBpbGUgdGltZS4gU28gY29tcGlsZXIgd2lsbCByZXBvcnQKPj4gdGhlIGJlbG93IHdhcm5pbmc6 Cj4+Cj4+IEluIGZpbGUgaW5jbHVkZWQgZnJvbSBpbmNsdWRlL2xpbnV4L2VsZi5oOjQ6MCwKPj4g ICAgICAgICAgICAgICAgICAgZnJvbSBmcy9wcm9jL3ZtY29yZS5jOjEzOgo+PiBmcy9wcm9jL3Zt Y29yZS5jOiBJbiBmdW5jdGlvbiAncGFyc2VfY3Jhc2hfZWxmMzJfaGVhZGVycyc6Cj4+IGFyY2gv bWlwcy9pbmNsdWRlL2FzbS9lbGYuaDoyNTg6MjM6IHdhcm5pbmc6IGluaXRpYWxpemF0aW8KPj4g biBmcm9tIGluY29tcGF0aWJsZSBwb2ludGVyIHR5cGUKPj4gICAgc3RydWN0IGVsZmhkciAqX19o ID0gKGhkcik7ICAgICBcCj4+ICAgICAgICAgICAgICAgICAgICAgICAgIF4KPj4gZnMvcHJvYy92 bWNvcmUuYzoxMDcxOjQ6IG5vdGU6IGluIGV4cGFuc2lvbiBvZiBtYWNybyAnZWxmXwo+PiBjaGVj a19hcmNoJwo+PiAgICAgIWVsZl9jaGVja19hcmNoKCZlaGRyKSB8fAo+PiAgICAgIF4KPj4KPj4g U2lnbmVkLW9mZi1ieTogWWFuamlhbmcgSmluIDx5YW5qaWFuZy5qaW5Ad2luZHJpdmVyLmNvbT4K Pj4gLS0tCj4+ICAgYXJjaC9taXBzL2luY2x1ZGUvYXNtL2VsZi5oIHwgNCArKy0tCj4+ICAgMSBm aWxlIGNoYW5nZWQsIDIgaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkKPj4KPj4gZGlmZiAt LWdpdCBhL2FyY2gvbWlwcy9pbmNsdWRlL2FzbS9lbGYuaCBiL2FyY2gvbWlwcy9pbmNsdWRlL2Fz bS9lbGYuaAo+PiBpbmRleCBmMTllODkwLi5lY2U0OTBkIDEwMDY0NAo+PiAtLS0gYS9hcmNoL21p cHMvaW5jbHVkZS9hc20vZWxmLmgKPj4gKysrIGIvYXJjaC9taXBzL2luY2x1ZGUvYXNtL2VsZi5o Cj4+IEBAIC0yMjQsNyArMjI0LDcgQEAgc3RydWN0IG1pcHNfZWxmX2FiaWZsYWdzX3YwIHsKPj4g ICAjZGVmaW5lIGVsZl9jaGVja19hcmNoKGhkcikgICAgICAgICAgICAgICAgICAgICAgICBcCj4+ ICAgKHsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBcCj4+ICAgICAgIGludCBf X3JlcyA9IDE7ICAgICAgICAgICAgICAgICAgICAgICAgICAgIFwKPj4gLSAgICBzdHJ1Y3QgZWxm aGRyICpfX2ggPSAoaGRyKTsgICAgICAgICAgICAgICAgICAgIFwKPj4gKyAgICBzdHJ1Y3QgZWxm aGRyICpfX2ggPSAoc3RydWN0IGVsZmhkciAqKShoZHIpOyAgICAgICAgICAgIFwKPj4gICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBcCj4+ICAgICAgIGlmIChfX2gtPmVfbWFj aGluZSAhPSBFTV9NSVBTKSAgICAgICAgICAgICAgICAgICAgXAo+PiAgICAgICAgICAgX19yZXMg PSAwOyAgICAgICAgICAgICAgICAgICAgICAgIFwKPj4gQEAgLTI1NSw3ICsyNTUsNyBAQCBzdHJ1 Y3QgbWlwc19lbGZfYWJpZmxhZ3NfdjAgewo+PiAgICNkZWZpbmUgZWxmX2NoZWNrX2FyY2goaGRy KSAgICAgICAgICAgICAgICAgICAgICAgIFwKPj4gICAoeyAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgIFwKPj4gICAgICAgaW50IF9fcmVzID0gMTsgICAgICAgICAgICAgICAgICAg ICAgICAgICAgXAo+PiAtICAgIHN0cnVjdCBlbGZoZHIgKl9faCA9IChoZHIpOyAgICAgICAgICAg ICAgICAgICAgXAo+PiArICAgIHN0cnVjdCBlbGZoZHIgKl9faCA9IChzdHJ1Y3QgZWxmaGRyICop KGhkcik7ICAgICAgICAgICAgXAo+PiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIFwKPj4gICAgICAgaWYgKF9faC0+ZV9tYWNoaW5lICE9IEVNX01JUFMpICAgICAgICAgICAg ICAgICAgICBcCj4+ICAgICAgICAgICBfX3JlcyA9IDA7ICAgICAgICAgICAgICAgICAgICAgICAg XAo+CgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18Ka2V4 ZWMgbWFpbGluZyBsaXN0CmtleGVjQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmlu ZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9rZXhlYwo= From mboxrd@z Thu Jan 1 00:00:00 1970 Received: with ECARTIS (v1.0.0; list linux-mips); Mon, 21 Sep 2015 04:23:27 +0200 (CEST) Received: from mail.windriver.com ([147.11.1.11]:61291 "EHLO mail.windriver.com" rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP id S27006916AbbIUCXZR0U4i (ORCPT ); Mon, 21 Sep 2015 04:23:25 +0200 Received: from ALA-HCA.corp.ad.wrs.com (ala-hca.corp.ad.wrs.com [147.11.189.40]) by mail.windriver.com (8.15.2/8.15.1) with ESMTPS id t8L2NGcD000770 (version=TLSv1 cipher=AES128-SHA bits=128 verify=FAIL); Sun, 20 Sep 2015 19:23:16 -0700 (PDT) Received: from [128.224.162.234] (128.224.162.234) by ALA-HCA.corp.ad.wrs.com (147.11.189.50) with Microsoft SMTP Server id 14.3.235.1; Sun, 20 Sep 2015 19:23:16 -0700 Message-ID: <55FF6A21.7030601@windriver.com> Date: Mon, 21 Sep 2015 10:23:29 +0800 From: yjin User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 MIME-Version: 1.0 To: CC: , , , , , , Subject: Re: [PATCH] mips: vmcore: forced convert 'hdr' in elf_check_arch() References: <1442562171-21307-1-git-send-email-yanjiang.jin@windriver.com> <1442562171-21307-2-git-send-email-yanjiang.jin@windriver.com> <55FF6876.7080908@windriver.com> In-Reply-To: <55FF6876.7080908@windriver.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit Return-Path: X-Envelope-To: <"|/home/ecartis/ecartis -s linux-mips"> (uid 0) X-Orcpt: rfc822;linux-mips@linux-mips.org Original-Recipient: rfc822;linux-mips@linux-mips.org X-archive-position: 49247 X-ecartis-version: Ecartis v1.0.0 Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org X-original-sender: yanjiang.jin@windriver.com Precedence: bulk List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: linux-mips X-List-ID: linux-mips List-subscribe: List-owner: List-post: List-archive: X-list: linux-mips It seems the last mail has been blocked, resend it. On 2015年09月21日 10:16, yjin wrote: > The new version patch only modifies mips/elf.h, so add Ralf Baechle > and cc linux-mips@linux-mips.org. > This is a V2 patch, attach the V1 patch for reference. > > Thanks! > Yanjiang > > On 2015年09月18日 15:42, yanjiang.jin@windriver.com wrote: >> From: Yanjiang Jin >> >> elf_check_arch() will be called both in parse_crash_elf64_headers() >> and parse_crash_elf32_headers(). But in these two functions, the type of >> the parameter ehdr is different: Elf32_Ehdr and Elf64_Ehdr. >> >> Function parse_crash_elf_headers() reads e_ident[EI_CLASS] then >> decides to >> call parse_crash_elf64_headers() or parse_crash_elf32_headers(). >> This happens in run time, not compile time. So compiler will report >> the below warning: >> >> In file included from include/linux/elf.h:4:0, >> from fs/proc/vmcore.c:13: >> fs/proc/vmcore.c: In function 'parse_crash_elf32_headers': >> arch/mips/include/asm/elf.h:258:23: warning: initializatio >> n from incompatible pointer type >> struct elfhdr *__h = (hdr); \ >> ^ >> fs/proc/vmcore.c:1071:4: note: in expansion of macro 'elf_ >> check_arch' >> !elf_check_arch(&ehdr) || >> ^ >> >> Signed-off-by: Yanjiang Jin >> --- >> arch/mips/include/asm/elf.h | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/arch/mips/include/asm/elf.h b/arch/mips/include/asm/elf.h >> index f19e890..ece490d 100644 >> --- a/arch/mips/include/asm/elf.h >> +++ b/arch/mips/include/asm/elf.h >> @@ -224,7 +224,7 @@ struct mips_elf_abiflags_v0 { >> #define elf_check_arch(hdr) \ >> ({ \ >> int __res = 1; \ >> - struct elfhdr *__h = (hdr); \ >> + struct elfhdr *__h = (struct elfhdr *)(hdr); \ >> \ >> if (__h->e_machine != EM_MIPS) \ >> __res = 0; \ >> @@ -255,7 +255,7 @@ struct mips_elf_abiflags_v0 { >> #define elf_check_arch(hdr) \ >> ({ \ >> int __res = 1; \ >> - struct elfhdr *__h = (hdr); \ >> + struct elfhdr *__h = (struct elfhdr *)(hdr); \ >> \ >> if (__h->e_machine != EM_MIPS) \ >> __res = 0; \ > From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.windriver.com ([147.11.1.11]:61291 "EHLO mail.windriver.com" rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP id S27006916AbbIUCXZR0U4i (ORCPT ); Mon, 21 Sep 2015 04:23:25 +0200 Message-ID: <55FF6A21.7030601@windriver.com> Date: Mon, 21 Sep 2015 10:23:29 +0800 From: yjin MIME-Version: 1.0 Subject: Re: [PATCH] mips: vmcore: forced convert 'hdr' in elf_check_arch() References: <1442562171-21307-1-git-send-email-yanjiang.jin@windriver.com> <1442562171-21307-2-git-send-email-yanjiang.jin@windriver.com> <55FF6876.7080908@windriver.com> In-Reply-To: <55FF6876.7080908@windriver.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit Return-Path: Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-subscribe: List-owner: List-post: List-archive: To: ralf@linux-mips.org Cc: akpm@linux-foundation.org, mhuang@redhat.com, kexec@lists.infradead.org, chaowang@redhat.com, linux-kernel@vger.kernel.org, jinyanjiang@gmail.com, linux-mips@linux-mips.org Message-ID: <20150921022329.MTynLUtm5AkiAzhqLvizjDjUW7qAn5TwWPQzg6Sdj-I@z> It seems the last mail has been blocked, resend it. On 2015年09月21日 10:16, yjin wrote: > The new version patch only modifies mips/elf.h, so add Ralf Baechle > and cc linux-mips@linux-mips.org. > This is a V2 patch, attach the V1 patch for reference. > > Thanks! > Yanjiang > > On 2015年09月18日 15:42, yanjiang.jin@windriver.com wrote: >> From: Yanjiang Jin >> >> elf_check_arch() will be called both in parse_crash_elf64_headers() >> and parse_crash_elf32_headers(). But in these two functions, the type of >> the parameter ehdr is different: Elf32_Ehdr and Elf64_Ehdr. >> >> Function parse_crash_elf_headers() reads e_ident[EI_CLASS] then >> decides to >> call parse_crash_elf64_headers() or parse_crash_elf32_headers(). >> This happens in run time, not compile time. So compiler will report >> the below warning: >> >> In file included from include/linux/elf.h:4:0, >> from fs/proc/vmcore.c:13: >> fs/proc/vmcore.c: In function 'parse_crash_elf32_headers': >> arch/mips/include/asm/elf.h:258:23: warning: initializatio >> n from incompatible pointer type >> struct elfhdr *__h = (hdr); \ >> ^ >> fs/proc/vmcore.c:1071:4: note: in expansion of macro 'elf_ >> check_arch' >> !elf_check_arch(&ehdr) || >> ^ >> >> Signed-off-by: Yanjiang Jin >> --- >> arch/mips/include/asm/elf.h | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/arch/mips/include/asm/elf.h b/arch/mips/include/asm/elf.h >> index f19e890..ece490d 100644 >> --- a/arch/mips/include/asm/elf.h >> +++ b/arch/mips/include/asm/elf.h >> @@ -224,7 +224,7 @@ struct mips_elf_abiflags_v0 { >> #define elf_check_arch(hdr) \ >> ({ \ >> int __res = 1; \ >> - struct elfhdr *__h = (hdr); \ >> + struct elfhdr *__h = (struct elfhdr *)(hdr); \ >> \ >> if (__h->e_machine != EM_MIPS) \ >> __res = 0; \ >> @@ -255,7 +255,7 @@ struct mips_elf_abiflags_v0 { >> #define elf_check_arch(hdr) \ >> ({ \ >> int __res = 1; \ >> - struct elfhdr *__h = (hdr); \ >> + struct elfhdr *__h = (struct elfhdr *)(hdr); \ >> \ >> if (__h->e_machine != EM_MIPS) \ >> __res = 0; \ >