From: Olliver Schinagl <o.schinagl@ultimaker.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/1] Kconfig: net: give PHYLIB to designware driver
Date: Mon, 21 Sep 2015 09:18:56 +0200 [thread overview]
Message-ID: <55FFAF60.3040502@ultimaker.com> (raw)
In-Reply-To: <CAEUhbmUviXB9ksV4oqY4y88xqJPdMbXoiL-0G8Z68RriuN5zhA@mail.gmail.com>
Hey Bin,
On 21-09-15 03:50, Bin Meng wrote:
> Hi Olliver,
>
> On Fri, Sep 18, 2015 at 11:29 PM, Olliver Schinagl
> <oliver+list@schinagl.nl> wrote:
>> From: Olliver Schinagl <o.schinagl@ultimaker.com>
>>
>> The designware driver has a build guard which makes it to only work when
>> using the PHYLIB. With b68fe152272 the PHYLIB was added to the net
>> Kconfig but not selected by all hardware depending on it.
>>
>> This patch enables PHYLIB for the Designware MAC
>>
>> Signed-off-by: Olliver Schinagl <o.schinagl@ultimaker.com>
>> ---
>> drivers/net/Kconfig | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
>> index bbec6a6..51b1668 100644
>> --- a/drivers/net/Kconfig
>> +++ b/drivers/net/Kconfig
>> @@ -79,10 +79,10 @@ config ETH_SANDBOX_RAW
>>
>> config ETH_DESIGNWARE
>> bool "Synopsys Designware Ethernet MAC"
>> + select PHYLIB
>> help
>> This MAC is present in SoCs from various vendors. It supports
>> - 100Mbit and 1 Gbit operation. You must enable CONFIG_PHYLIB to
>> - provide the PHY (physical media interface).
>> + 100Mbit and 1 Gbit operation.
>>
>> config PCH_GBE
>> bool "Intel Platform Controller Hub EG20T GMAC driver"
>> --
> This is not enough. You need update all borads' config.h files to
> remove CONFIG_PHYLIB, otherwise it causes redefinition warnings.
I was being conservative here,
Is it enough to only do the boards that are featured using Kconfig?
>
> Regards,
> Bin
--
Met vriendelijke groeten, Kind regards, ??????
Olliver Schinagl
Research & Development
Ultimaker B.V.
next prev parent reply other threads:[~2015-09-21 7:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-18 15:29 [U-Boot] [PATCH 1/1] Kconfig: net: give PHYLIB to designware driver Olliver Schinagl
2015-09-21 1:50 ` Bin Meng
2015-09-21 7:18 ` Olliver Schinagl [this message]
2015-09-21 7:24 ` Bin Meng
2015-09-21 8:08 ` Olliver Schinagl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55FFAF60.3040502@ultimaker.com \
--to=o.schinagl@ultimaker.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.