From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56268) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zdw6a-0005VL-4I for qemu-devel@nongnu.org; Mon, 21 Sep 2015 04:05:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zdw6W-0005q7-Um for qemu-devel@nongnu.org; Mon, 21 Sep 2015 04:05:44 -0400 Received: from e06smtp15.uk.ibm.com ([195.75.94.111]:45190) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zdw6W-0005oU-3o for qemu-devel@nongnu.org; Mon, 21 Sep 2015 04:05:40 -0400 Received: from /spool/local by e06smtp15.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 21 Sep 2015 09:05:37 +0100 Received: from b06cxnps4076.portsmouth.uk.ibm.com (d06relay13.portsmouth.uk.ibm.com [9.149.109.198]) by d06dlp01.portsmouth.uk.ibm.com (Postfix) with ESMTP id D6A6817D8059 for ; Mon, 21 Sep 2015 09:06:10 +0100 (BST) Received: from d06av02.portsmouth.uk.ibm.com (d06av02.portsmouth.uk.ibm.com [9.149.37.228]) by b06cxnps4076.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id t8L84Je121758074 for ; Mon, 21 Sep 2015 08:04:19 GMT Received: from d06av02.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av02.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id t8L84JtR008285 for ; Mon, 21 Sep 2015 02:04:19 -0600 References: <1442677004-4482-1-git-send-email-afaerber@suse.de> <1442677004-4482-3-git-send-email-afaerber@suse.de> From: Christian Borntraeger Message-ID: <55FFBA02.5070501@de.ibm.com> Date: Mon, 21 Sep 2015 10:04:18 +0200 MIME-Version: 1.0 In-Reply-To: <1442677004-4482-3-git-send-email-afaerber@suse.de> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH 2/6] hw/s390x/css: Use type_init() instead of machine_init() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?Q?Andreas_F=c3=a4rber?= , qemu-devel@nongnu.org Cc: Cornelia Huck , Alexander Graf , Richard Henderson Am 19.09.2015 um 17:36 schrieb Andreas Färber: > Here, machine_init() is being misused to initialize global variables. > Being all local, it's safe to use the slightly earlier type_init(). > > This prepares for dropping machine_init(). > > Signed-off-by: Andreas Färber Acked-by: Christian Borntraeger I think this should go via your tree to coordinate with machine_init removal. > --- > hw/s390x/css.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/s390x/css.c b/hw/s390x/css.c > index c033612..d164fa8 100644 > --- a/hw/s390x/css.c > +++ b/hw/s390x/css.c > @@ -1509,7 +1509,7 @@ static void css_init(void) > channel_subsys->chnmon_active = false; > QTAILQ_INIT(&channel_subsys->io_adapters); > } > -machine_init(css_init); > +type_init(css_init) > > void css_reset_sch(SubchDev *sch) > { >