From: Michal Privoznik <mprivozn@redhat.com>
To: Lasya <comethalley61@gmail.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [FIRST-PATCH] updated the negation STREQ to STRNEQ
Date: Mon, 21 Sep 2015 13:05:59 +0200 [thread overview]
Message-ID: <55FFE497.3010503@redhat.com> (raw)
In-Reply-To: <1442674777-14793-1-git-send-email-comethalley61@gmail.com>
[You've got the wrong list. This is a libvirt patch and as such it
should have been sent to the libvir-list@redhat.com]
On 19.09.2015 16:59, Lasya wrote:
> Hi,
> This is my first patch in QEMU. I have solved a bite-sized bug. I have updated the !STREQ with STRNEQ in the following files. Thanks.
>
> ---
> src/bhyve/bhyve_driver.c | 2 +-
> src/conf/network_conf.c | 4 ++--
> src/conf/nwfilter_conf.c | 2 +-
> src/conf/nwfilter_params.c | 2 +-
> src/conf/storage_conf.c | 2 +-
> src/lxc/lxc_fuse.c | 4 ++--
> src/openvz/openvz_driver.c | 2 +-
> src/qemu/qemu_command.c | 6 +++---
> src/qemu/qemu_domain.c | 2 +-
> src/qemu/qemu_hotplug.c | 2 +-
> src/security/security_manager.c | 2 +-
> src/security/security_selinux.c | 12 ++++++------
> src/storage/storage_backend_logical.c | 2 +-
> src/util/virfile.c | 2 +-
> src/util/virsystemd.c | 2 +-
> src/vz/vz_driver.c | 2 +-
> src/vz/vz_sdk.c | 2 +-
> src/xen/xend_internal.c | 2 +-
> src/xenconfig/xen_sxpr.c | 2 +-
> tests/commandtest.c | 10 +++++-----
> tests/securityselinuxlabeltest.c | 2 +-
> tests/virauthconfigtest.c | 2 +-
> tests/virbitmaptest.c | 12 ++++++------
> tests/vircgrouptest.c | 2 +-
> tests/virkeyfiletest.c | 8 ++++----
> tests/virnetsockettest.c | 2 +-
> tests/virtypedparamtest.c | 2 +-
> tests/viruritest.c | 16 ++++++++--------
> 28 files changed, 56 insertions(+), 56 deletions(-)
Okay, you've got all the occurrences. However, the syntax-check rule is
missing. You may want to look at cfg.mk for some examples. syntax-check
is our make target that checks the code if it complies with our coding
standards. After this patch we want a rule that forbids !STREQ or !STRNEQ.
Otherwise looking very good. Looking forward to v2.
Michal
next prev parent reply other threads:[~2015-09-21 11:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-19 14:59 [Qemu-devel] [FIRST-PATCH] updated the negation STREQ to STRNEQ Lasya
2015-09-21 11:05 ` Michal Privoznik [this message]
2015-09-21 11:08 ` Michal Privoznik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55FFE497.3010503@redhat.com \
--to=mprivozn@redhat.com \
--cc=comethalley61@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.