Re: [PATCH liburing 3/4] tests: add tests for zerocopy send and notifications

[Ammar Faizi <ammarfaizi2@gnuweeb.org>]

From: Ammar Faizi <ammarfaizi2@gnuweeb.org>
Subject: [PATCH] helpers.h: Kill T_EXIT_ERROR because it's not used

This value is not used anywhere in liburing tests and we are not
going to make a distinction between FAIL and ERROR. Kill it to
avoid confusion in choosing them. Just always use T_EXIT_FAIL
whenever we fail.

Cc: Eli Schwartz <eschwartz93@gmail.com>
Link: https://lore.kernel.org/io-uring/eb9f8e37-a3b5-0b87-4f90-7ec80772e3fb@kernel.dk
Signed-off-by: Ammar Faizi <ammarfaizi2@gnuweeb.org>
---

On Mon, 25 Jul 2022 17:37:03 -0600, Jens Axboe wrote:
> I think we should kill that, it just causes confusion and I generally
> hate adding infrastructure that isn't even being used.

The killing patch below...

 test/helpers.h | 1 -
 1 file changed, 1 deletion(-)

diff --git a/test/helpers.h b/test/helpers.h
index fbfd7d1..6d5726c 100644
--- a/test/helpers.h
+++ b/test/helpers.h
@@ -20,7 +20,6 @@ enum t_test_result {
 	T_EXIT_PASS   = 0,
 	T_EXIT_FAIL   = 1,
 	T_EXIT_SKIP   = 77,
-	T_EXIT_ERROR  = 99,
 };
 
 /*

base-commit: 30a20795d7e4f300c606c6a2aa0a4c9492882d1d
-- 
Ammar Faizi