From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>,
intel-gfx@lists.freedesktop.org,
Patchwork <patchwork@emeril.freedesktop.org>
Subject: Re: ✓ Fi.CI.IGT: success for RFC drm/i915/pmu: Avoid sleeping rpm_get under atomic PMU read
Date: Mon, 5 Feb 2018 13:37:42 +0000 [thread overview]
Message-ID: <55d52aa1-5d64-dd2f-77c3-5e855ba3c704@linux.intel.com> (raw)
In-Reply-To: <151783673061.15322.9627316353186673680@mail.alporthouse.com>
On 05/02/2018 13:18, Chris Wilson wrote:
> Quoting Tvrtko Ursulin (2018-02-05 11:45:17)
>>
>> On 05/02/2018 10:31, Patchwork wrote:
>>> == Series Details ==
>>>
>>> Series: RFC drm/i915/pmu: Avoid sleeping rpm_get under atomic PMU read
>>> URL : https://patchwork.freedesktop.org/series/37644/
>>> State : success
>>>
>>> == Summary ==
>>>
>>> Test perf_pmu:
>>> Subgroup busy-double-start-vcs0:
>>> pass -> INCOMPLETE (shard-apl) fdo#103927
>>
>> This is most probably the race "drm/i915/pmu: Fix PMU enable vs
>> execlists tasklet race" will fix once merged.
>
> I was hoping to see some pmu-rc6 oddity to write off the patch. :|
Albeit not ideal some fix is needed.
Maybe move to timer sampling and assume RC6 grows by PERIOD while device
is suspended, then when awake, make sure we don't add the real RC6
counter until it catches up with the faked value. So to ensure no
backwards jumps? It should catch up eventually, unless there is no RC6
at all. Hm, can we detect that in the very beginning?
Regards,
Tvrtko
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2018-02-05 13:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-05 9:11 [PATCH] RFC drm/i915/pmu: Avoid sleeping rpm_get under atomic PMU read Chris Wilson
2018-02-05 9:40 ` ✓ Fi.CI.BAT: success for " Patchwork
2018-02-05 9:47 ` [PATCH] " Tvrtko Ursulin
2018-02-05 9:50 ` Chris Wilson
2018-02-05 10:31 ` ✓ Fi.CI.IGT: success for " Patchwork
2018-02-05 11:45 ` Tvrtko Ursulin
2018-02-05 13:18 ` Chris Wilson
2018-02-05 13:37 ` Tvrtko Ursulin [this message]
2018-02-05 13:43 ` Chris Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55d52aa1-5d64-dd2f-77c3-5e855ba3c704@linux.intel.com \
--to=tvrtko.ursulin@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=patchwork@emeril.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.