From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 995D2C43334 for ; Sat, 9 Jul 2022 18:30:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229528AbiGISag (ORCPT ); Sat, 9 Jul 2022 14:30:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51090 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229450AbiGISaf (ORCPT ); Sat, 9 Jul 2022 14:30:35 -0400 Received: from mail-wr1-x42a.google.com (mail-wr1-x42a.google.com [IPv6:2a00:1450:4864:20::42a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4D60F22BF1; Sat, 9 Jul 2022 11:30:34 -0700 (PDT) Received: by mail-wr1-x42a.google.com with SMTP id z12so2198512wrq.7; Sat, 09 Jul 2022 11:30:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=UzXTEzvirVIfQgpRsZ+S3IQH5KHrdqAU7esxyuqlcI4=; b=azFPTNNmWWMPgUFKlPXqmgq48Ky1+NFueWA8CeF4u6bOZNNqI/ZouXYtrZzIQI8369 tHNRrJbP3Sk+Qceww9e7NnrcuDgJ6oXsFN+7UXhcMdUokeJ6YJlHAlJxMvos2ldKLn3j 7qnyIMJNcvc4n+99h6ZoUqIl96IBxZcSLUP2Row3p9htPHtQDjaOVGMxEPZIg0ThAzku JP/YMWoEj/7gz/zYLt8XR5fUmxUTGzc7A4L/NsKoD1clU44nb9/glj7xUMteE9ztqdCY xScs/VQryAk4+7BFaPGN8I56D8qyIDvJpCmOtxLQds1DYNF1pzvoTJw1JwfwK48t37Iw OhgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=UzXTEzvirVIfQgpRsZ+S3IQH5KHrdqAU7esxyuqlcI4=; b=1WErL9gRAaSUpnV0O/zACf4Otbi+i9fUONTvA1FYoTZAuIbhVSkeUPGZjUQ9YyBTmH s73OnP6+Oug3htKeQDoK+MOhoQhiB9xFNUQuY8oBrN/yBEMa3cdGA6cXoAJ6sUZ9HTsK yHGXkUcZDxjfmf3XV03kem1hgF9T5ARn3kgGHjLCjwOcr5Pht+NRpLe/W+c5BAcbDZNI l42wgKlTbWBBQM01NTFuj33NUKD7y5/Vq6bfSpXBVmrMvp0cugi8Gp/6blFABvnjIysU NJ1nrL4RBcbwmAIklKSndGKM9ENUo7ACqT9gr+Vr+JlWSXVpAPfAb11/A4eJZYtig5vI sgYg== X-Gm-Message-State: AJIora9C/tSKcYWnLs92tN6Gylh1OvJFoP3SKmiI/ZQb9pgeOKR+QzKe +aHHJOBSOFWVU6I0rcBk1Bk= X-Google-Smtp-Source: AGRyM1tAtrtLBOTNfS7tOy8h/BBFOAIT9pR7nVNc89ZMI3mrlIbdzOc1A9K2XpDn13ZLjn4N3vi0ng== X-Received: by 2002:adf:e0c9:0:b0:21b:8271:2348 with SMTP id m9-20020adfe0c9000000b0021b82712348mr8620979wri.222.1657391432677; Sat, 09 Jul 2022 11:30:32 -0700 (PDT) Received: from opensuse.localnet (host-95-235-102-55.retail.telecomitalia.it. [95.235.102.55]) by smtp.gmail.com with ESMTPSA id j9-20020a05600c190900b0039db31f6372sm6358721wmq.2.2022.07.09.11.30.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 09 Jul 2022 11:30:31 -0700 (PDT) From: "Fabio M. De Francesco" To: Ira Weiny Cc: Benjamin LaHaise , Alexander Viro , Eric Biederman , Kees Cook , Dan Williams , Matthew Wilcox , Jan Kara , Jeff Layton , Chuck Lever , Jens Axboe , Pavel Begunkov , Thomas Gleixner , Paul Walmsley , Palmer Dabbelt , Albert Ou , Nathan Chancellor , Nick Desaulniers , Tom Rix , linux-aio@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, nvdimm@lists.linux.dev, io-uring@vger.kernel.org, linux-riscv@lists.infradead.org, llvm@lists.linux.dev Subject: Re: [PATCH] fs: Replace kmap{,_atomic}() with kmap_local_page() Date: Sat, 09 Jul 2022 20:30:28 +0200 Message-ID: <5600017.DvuYhMxLoT@opensuse> In-Reply-To: References: <20220630163527.9776-1-fmdefrancesco@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Precedence: bulk List-ID: X-Mailing-List: io-uring@vger.kernel.org On venerd=C3=AC 8 luglio 2022 22:18:35 CEST Ira Weiny wrote: > On Thu, Jun 30, 2022 at 06:35:27PM +0200, Fabio M. De Francesco wrote: > > The use of kmap() and kmap_atomic() are being deprecated in favor of > > kmap_local_page(). > >=20 > > With kmap_local_page(), the mappings are per thread, CPU local and not > > globally visible. Furthermore, the mappings can be acquired from any > > context (including interrupts). > >=20 > > Therefore, use kmap_local_page() in exec.c because these mappings are=20 per > > thread, CPU local, and not globally visible. > >=20 > > Tested with xfstests on a QEMU + KVM 32-bits VM booting a kernel with > > HIGHMEM64GB enabled. > >=20 > > Suggested-by: Ira Weiny >=20 > This looks good but there is a kmap_atomic() in this file which I _think_= =20 can > be converted as well. But that is good as a separate patch. >=20 > Reviewed-by: Ira Weiny >=20 Thanks for your review! I didn't notice that kmap_atomic(). I'll send a conversion with a separate= =20 patch. =46abio From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5895CC43334 for ; Sat, 9 Jul 2022 18:30:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=W7CWRYrdzct+wmKhH5P7egMsuG7OizZSTFjKz9fpgFk=; b=kypJqezlBwJkv2 Z3aN/bSW1oFlX/gONtJZh/6bXjCXSGvB7eHTHqBE7fgncTGYQ/4ZEh2GfTU5HXen5rrFq6oZNaHOR xv9XTl39vmVRH6dlz3r081qxMjScj1YnOtvSwvZFXoNarw5z/KHiLv7odvoPaV16z3TlerNaZT7QM ryvyD11hgDyEsIglB8Nw+ilPWwgNYDih7+aIP9xWjrjB78HNzYGnMlfbkqpZVnjHp9uVKR0mohzw2 w4qj4pGPtwoX9L12xORzOqIMLCsZ80JZLZFK1Z6XfNRwIcUFur3IYyXzV56PYVvEnm/DIeIhsfW+j s28/LIXJdWMHOuO57WgQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oAFDx-008tnp-7n; Sat, 09 Jul 2022 18:30:37 +0000 Received: from mail-wr1-x430.google.com ([2a00:1450:4864:20::430]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oAFDv-008tmX-4O for linux-riscv@lists.infradead.org; Sat, 09 Jul 2022 18:30:36 +0000 Received: by mail-wr1-x430.google.com with SMTP id o4so2218675wrh.3 for ; Sat, 09 Jul 2022 11:30:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=UzXTEzvirVIfQgpRsZ+S3IQH5KHrdqAU7esxyuqlcI4=; b=azFPTNNmWWMPgUFKlPXqmgq48Ky1+NFueWA8CeF4u6bOZNNqI/ZouXYtrZzIQI8369 tHNRrJbP3Sk+Qceww9e7NnrcuDgJ6oXsFN+7UXhcMdUokeJ6YJlHAlJxMvos2ldKLn3j 7qnyIMJNcvc4n+99h6ZoUqIl96IBxZcSLUP2Row3p9htPHtQDjaOVGMxEPZIg0ThAzku JP/YMWoEj/7gz/zYLt8XR5fUmxUTGzc7A4L/NsKoD1clU44nb9/glj7xUMteE9ztqdCY xScs/VQryAk4+7BFaPGN8I56D8qyIDvJpCmOtxLQds1DYNF1pzvoTJw1JwfwK48t37Iw OhgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=UzXTEzvirVIfQgpRsZ+S3IQH5KHrdqAU7esxyuqlcI4=; b=XOVt0xTM0+j29qYXrilcl3WiNrxFRMxMmrktXQqb1W+Um5vurUpd5zyc4h57zQdNew 3G1l7mRu/kfPwT5LXpKxHUObPHI6kLaQe/QN6nv2Eum9UpVMWvJvoVzQ0izTAr5ym0bP EfOzOlyE+7xNRtzhqEE4otFqpiTnokdfCF79yg1BmZw5wVbTVGhChjmlMWtf7jwgw3ZT x+AXGBWMUbD59TjF9HjhTe4XZtYC1g9NRPTnhAo9/Pg6IRyap98ZMoJEAEutk5AjPngT 56jdIL3I9b+WXb29GOzC4EzyRThxuP1/Ne81DryyOxqmxxG7m5WYaocZ/EZgwHZgWfdE Oq7Q== X-Gm-Message-State: AJIora/cqJ8lCbjKAWZCAy/16e8p2ZdUtedaaZ0olIOnXBFa0yObtdGm tvsjBs0hNUycvv9qB+oZqfk= X-Google-Smtp-Source: AGRyM1tAtrtLBOTNfS7tOy8h/BBFOAIT9pR7nVNc89ZMI3mrlIbdzOc1A9K2XpDn13ZLjn4N3vi0ng== X-Received: by 2002:adf:e0c9:0:b0:21b:8271:2348 with SMTP id m9-20020adfe0c9000000b0021b82712348mr8620979wri.222.1657391432677; Sat, 09 Jul 2022 11:30:32 -0700 (PDT) Received: from opensuse.localnet (host-95-235-102-55.retail.telecomitalia.it. [95.235.102.55]) by smtp.gmail.com with ESMTPSA id j9-20020a05600c190900b0039db31f6372sm6358721wmq.2.2022.07.09.11.30.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 09 Jul 2022 11:30:31 -0700 (PDT) From: "Fabio M. De Francesco" To: Ira Weiny Cc: Benjamin LaHaise , Alexander Viro , Eric Biederman , Kees Cook , Dan Williams , Matthew Wilcox , Jan Kara , Jeff Layton , Chuck Lever , Jens Axboe , Pavel Begunkov , Thomas Gleixner , Paul Walmsley , Palmer Dabbelt , Albert Ou , Nathan Chancellor , Nick Desaulniers , Tom Rix , linux-aio@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, nvdimm@lists.linux.dev, io-uring@vger.kernel.org, linux-riscv@lists.infradead.org, llvm@lists.linux.dev Subject: Re: [PATCH] fs: Replace kmap{,_atomic}() with kmap_local_page() Date: Sat, 09 Jul 2022 20:30:28 +0200 Message-ID: <5600017.DvuYhMxLoT@opensuse> In-Reply-To: References: <20220630163527.9776-1-fmdefrancesco@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220709_113035_212313_CB143503 X-CRM114-Status: GOOD ( 13.07 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org T24gdmVuZXJkw6wgOCBsdWdsaW8gMjAyMiAyMjoxODozNSBDRVNUIElyYSBXZWlueSB3cm90ZToK PiBPbiBUaHUsIEp1biAzMCwgMjAyMiBhdCAwNjozNToyN1BNICswMjAwLCBGYWJpbyBNLiBEZSBG cmFuY2VzY28gd3JvdGU6Cj4gPiBUaGUgdXNlIG9mIGttYXAoKSBhbmQga21hcF9hdG9taWMoKSBh cmUgYmVpbmcgZGVwcmVjYXRlZCBpbiBmYXZvciBvZgo+ID4ga21hcF9sb2NhbF9wYWdlKCkuCj4g PiAKPiA+IFdpdGgga21hcF9sb2NhbF9wYWdlKCksIHRoZSBtYXBwaW5ncyBhcmUgcGVyIHRocmVh ZCwgQ1BVIGxvY2FsIGFuZCBub3QKPiA+IGdsb2JhbGx5IHZpc2libGUuIEZ1cnRoZXJtb3JlLCB0 aGUgbWFwcGluZ3MgY2FuIGJlIGFjcXVpcmVkIGZyb20gYW55Cj4gPiBjb250ZXh0IChpbmNsdWRp bmcgaW50ZXJydXB0cykuCj4gPiAKPiA+IFRoZXJlZm9yZSwgdXNlIGttYXBfbG9jYWxfcGFnZSgp IGluIGV4ZWMuYyBiZWNhdXNlIHRoZXNlIG1hcHBpbmdzIGFyZSAKcGVyCj4gPiB0aHJlYWQsIENQ VSBsb2NhbCwgYW5kIG5vdCBnbG9iYWxseSB2aXNpYmxlLgo+ID4gCj4gPiBUZXN0ZWQgd2l0aCB4 ZnN0ZXN0cyBvbiBhIFFFTVUgKyBLVk0gMzItYml0cyBWTSBib290aW5nIGEga2VybmVsIHdpdGgK PiA+IEhJR0hNRU02NEdCIGVuYWJsZWQuCj4gPiAKPiA+IFN1Z2dlc3RlZC1ieTogSXJhIFdlaW55 IDxpcmEud2VpbnlAaW50ZWwuY29tPgo+IAo+IFRoaXMgbG9va3MgZ29vZCBidXQgdGhlcmUgaXMg YSBrbWFwX2F0b21pYygpIGluIHRoaXMgZmlsZSB3aGljaCBJIF90aGlua18gCmNhbgo+IGJlIGNv bnZlcnRlZCBhcyB3ZWxsLiAgQnV0IHRoYXQgaXMgZ29vZCBhcyBhIHNlcGFyYXRlIHBhdGNoLgo+ IAo+IFJldmlld2VkLWJ5OiBJcmEgV2VpbnkgPGlyYS53ZWlueUBpbnRlbC5jb20+Cj4gCgpUaGFu a3MgZm9yIHlvdXIgcmV2aWV3IQoKSSBkaWRuJ3Qgbm90aWNlIHRoYXQga21hcF9hdG9taWMoKS4g SSdsbCBzZW5kIGEgY29udmVyc2lvbiB3aXRoIGEgc2VwYXJhdGUgCnBhdGNoLgoKRmFiaW8KCgoK Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LXJp c2N2IG1haWxpbmcgbGlzdApsaW51eC1yaXNjdkBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9s aXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtcmlzY3YK