From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH 3/5] bnx2x: Add RTE_LIBRTE_BNX2X_REG_ACCESS config option Date: Sat, 07 Nov 2015 22:53:33 +0100 Message-ID: <5600189.IfZWYQEBpk@xps13> References: <1442018576-19981-1-git-send-email-rasesh.mody@qlogic.com> <6673500.WzqtfFB45U@xps13> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, Sony Chacko To: Harish Patil Return-path: Received: from mail-wm0-f42.google.com (mail-wm0-f42.google.com [74.125.82.42]) by dpdk.org (Postfix) with ESMTP id 61D145A53 for ; Sat, 7 Nov 2015 22:54:44 +0100 (CET) Received: by wmww144 with SMTP id w144so5451081wmw.0 for ; Sat, 07 Nov 2015 13:54:44 -0800 (PST) In-Reply-To: List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > >Either other "debug" logs can be put as INFO level, or > >you need a level 9 for verbose debug. > >But I don't really understand what is the problem of a verbose debug. > > > >It is not critical for the acceptance of this patch. Just wanted to > >discuss > >it as we have many config options to tune the debug. > > > >Please, at least, use the DEBUG word in the option name as done for > >CONFIG_RTE_LIBRTE_BNX2X_DEBUG_RX. > > > > Currently PMD_DRV_LOG(DEBUG,..) is used all over the places and converting > that into INFO/NOTICE levels results in lot of changes. Having a lot of changes to do is not a good argument. But that's an argument to reduce the size of the bnx2x driver. And more generally, this driver would deserve some big changes. > Even if we convert other debug logs as INFO level logs, since level 8 is > the default debug level, the user would have to edit config file to > prevent flooding of the messages on the console. The user *should* change the log evel in most cases. Or we could raise the default level to INFO. And users of packaged DPDK may already have a different configuration from the distribution. > So I guess adding a debug > option without needing additional level would suffice for now. I shall > rename it as CONFIG_RTE_LIBRTE_BNX2X_DEBUG_PERIODIC and include all > periodic events like statistics, register R/Ws etc under this debug. Yes it could work. But it would be nice to have a consistent log management across drivers.