From: "Andrew F. Davis" <afd@ti.com>
To: Mark Brown <broonie@kernel.org>
Cc: Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
Linus Walleij <linus.walleij@linaro.org>,
Alexandre Courbot <gnurou@gmail.com>,
Samuel Ortiz <sameo@linux.intel.com>,
Lee Jones <lee.jones@linaro.org>,
Liam Girdwood <lgirdwood@gmail.com>,
devicetree@vger.kernel.org, linux-gpio@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] mfd: tps65912: Rewrite driver adding DT support and using regmap
Date: Mon, 21 Sep 2015 14:46:50 -0500 [thread overview]
Message-ID: <56005EAA.3000208@ti.com> (raw)
In-Reply-To: <20150921192645.GA30445@sirena.org.uk>
On 09/21/2015 02:26 PM, Mark Brown wrote:
> On Mon, Sep 21, 2015 at 11:42:13AM -0500, Andrew F. Davis wrote:
>
>> I know this is hard to review, and so I would like to apologize in advance, but
>> the regulator and GPIO changes depend on the new driver core, as do the i2c/spi
>> components. I really don't know how to split this up without leaving some part
>> in a non-working state in-between patches (which I've heard is also not OK).
>
> So split that interface change between the MFD and the function drivers
> out into a separate change - you've got way more than just an interface
> change in here (and you've not enumerated the various things that are
> being changed in the changelog).
>
I'm not really "changing" anything, this is a ground-up re-write. This
fundamentally changes the way the MFD core and the function drivers interact,
I would consider this a whole new driver that just happens to replace an older
driver, not a bunch of incremental changes although I kept the same filenames.
WARNING: multiple messages have this Message-ID (diff)
From: "Andrew F. Davis" <afd@ti.com>
To: Mark Brown <broonie@kernel.org>
Cc: Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
Linus Walleij <linus.walleij@linaro.org>,
Alexandre Courbot <gnurou@gmail.com>,
Samuel Ortiz <sameo@linux.intel.com>,
Lee Jones <lee.jones@linaro.org>,
Liam Girdwood <lgirdwood@gmail.com>, <devicetree@vger.kernel.org>,
<linux-gpio@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/3] mfd: tps65912: Rewrite driver adding DT support and using regmap
Date: Mon, 21 Sep 2015 14:46:50 -0500 [thread overview]
Message-ID: <56005EAA.3000208@ti.com> (raw)
In-Reply-To: <20150921192645.GA30445@sirena.org.uk>
On 09/21/2015 02:26 PM, Mark Brown wrote:
> On Mon, Sep 21, 2015 at 11:42:13AM -0500, Andrew F. Davis wrote:
>
>> I know this is hard to review, and so I would like to apologize in advance, but
>> the regulator and GPIO changes depend on the new driver core, as do the i2c/spi
>> components. I really don't know how to split this up without leaving some part
>> in a non-working state in-between patches (which I've heard is also not OK).
>
> So split that interface change between the MFD and the function drivers
> out into a separate change - you've got way more than just an interface
> change in here (and you've not enumerated the various things that are
> being changed in the changelog).
>
I'm not really "changing" anything, this is a ground-up re-write. This
fundamentally changes the way the MFD core and the function drivers interact,
I would consider this a whole new driver that just happens to replace an older
driver, not a bunch of incremental changes although I kept the same filenames.
next prev parent reply other threads:[~2015-09-21 19:47 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-15 17:57 [PATCH 0/3] mfd: tps65912: Driver rewrite with DT support Andrew F. Davis
2015-09-15 17:57 ` Andrew F. Davis
2015-09-15 17:57 ` [PATCH 1/3] Documentation: tps65912: Add DT bindings for the TPS65912 PMIC Andrew F. Davis
2015-09-15 17:57 ` Andrew F. Davis
2015-09-20 4:16 ` Lee Jones
2015-09-21 16:32 ` Andrew F. Davis
2015-09-21 16:32 ` Andrew F. Davis
2015-09-21 23:07 ` Lee Jones
2015-09-21 23:07 ` Lee Jones
2015-09-22 19:58 ` Andrew F. Davis
2015-09-22 19:58 ` Andrew F. Davis
2015-09-15 17:57 ` [PATCH 2/3] mfd: tps65912: Rewrite driver adding DT support and using regmap Andrew F. Davis
2015-09-15 17:57 ` Andrew F. Davis
2015-09-19 18:40 ` Mark Brown
2015-09-21 16:42 ` Andrew F. Davis
2015-09-21 16:42 ` Andrew F. Davis
2015-09-21 19:26 ` Mark Brown
2015-09-21 19:46 ` Andrew F. Davis [this message]
2015-09-21 19:46 ` Andrew F. Davis
2015-09-21 19:54 ` Mark Brown
[not found] ` <20150921195457.GD30445-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2015-09-21 19:59 ` Andrew F. Davis
2015-09-21 19:59 ` Andrew F. Davis
2015-09-20 4:16 ` Lee Jones
2015-09-21 18:22 ` Andrew F. Davis
2015-09-21 18:22 ` Andrew F. Davis
[not found] ` <56004AE8.5030504-l0cyMroinI0@public.gmane.org>
2015-09-21 23:04 ` Lee Jones
2015-09-21 23:04 ` Lee Jones
2015-09-15 17:57 ` [PATCH 3/3] tps65912: Cleanup TPS65912 subdevice configuration dependencies Andrew F. Davis
2015-09-15 17:57 ` Andrew F. Davis
2015-09-16 19:57 ` Mark Brown
2015-10-02 10:23 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56005EAA.3000208@ti.com \
--to=afd@ti.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=gnurou@gmail.com \
--cc=ijc+devicetree@hellion.org.uk \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.