From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from bear.ext.ti.com ([192.94.94.41]:60182 "EHLO bear.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932422AbbIUWMx (ORCPT ); Mon, 21 Sep 2015 18:12:53 -0400 Message-ID: <560080ED.6090607@ti.com> Date: Mon, 21 Sep 2015 18:13:01 -0400 From: Murali Karicheri MIME-Version: 1.0 To: , CC: "rmk+kernel@arm.linux.org.uk >> Russell King" Subject: request to merge commit 3302caddf10ad50710dbb7a94ccbdb3ad5bf1412 Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Sender: stable-owner@vger.kernel.org List-ID: Hi Maintainer, The below commit fixes the Warning shown in the trace below when debug options are enabled in the kernel build. Could you please merge this to address the issue for v4.1.9? Thanks ============================================================================ commit 3302caddf10ad50710dbb7a94ccbdb3ad5bf1412 Author: Russell King Date: Thu Aug 20 16:13:37 2015 +0100 ARM: entry: efficiency cleanups Make the "fast" syscall return path fast again. The addition of IRQ tracing and context tracking has made this path grossly inefficient. We can do much better if these options are enabled if we save the syscall return code on the stack - we then don't need to save a bunch of registers around every single callout to C code. Acked-by: Will Deacon Signed-off-by: Russell King ================================================================================ Warning log below which is addressed by above commit. [ 17.401337] ------------[ cut here ]------------ [ 17.405991] WARNING: CPU: 2 PID: 1201 at kernel/locking/lockdep.c:3557 check_flags.part.37+0x224/0x228() [ 17.415508] DEBUG_LOCKS_WARN_ON(current->hardirqs_enabled) [ 17.420836] Modules linked in: [ 17.424087] CPU: 2 PID: 1201 Comm: udevd Tainted: G W 4.1.6-01270-gcdac6fd #1 [ 17.432379] Hardware name: Keystone [ 17.435894] [] (unwind_backtrace) from [] (show_stack+0x10/0x14) [ 17.443673] [] (show_stack) from [] (dump_stack+0x84/0xc4) [ 17.450926] [] (dump_stack) from [] (warn_slowpath_common+0x84/0xb4) [ 17.459048] [] (warn_slowpath_common) from [] (warn_slowpath_fmt+0x30/0x40) [ 17.467781] [] (warn_slowpath_fmt) from [] (check_flags.part.37+0x224/0x228) [ 17.476601] [] (check_flags.part.37) from [] (lock_is_held+0x88/0x94) [ 17.484811] [] (lock_is_held) from [] (rcu_note_context_switch+0x854/0x8c0) [ 17.493545] [] (rcu_note_context_switch) from [] (__schedule+0x40/0x844) [ 17.502017] [] (__schedule) from [] (schedule+0x40/0x98) [ 17.509097] [] (schedule) from [] (do_work_pending+0x24/0xb0) [ 17.516610] [] (do_work_pending) from [] (work_pending+0xc/0x20) [ 17.524380] ---[ end trace fe0042166f5d3227 ]--- [ 17.529009] possible reason: unannotated irqs-off. [ 17.533813] irq event stamp: 331979 [ 17.537308] hardirqs last enabled at (331979): [] no_work_pending+0x8/0x30 [ 17.545172] hardirqs last disabled at (331978): [] ret_slow_syscall+0xc/0x10 [ 17.553123] softirqs last enabled at (327182): [] __do_softirq+0x4dc/0x6cc [ 17.560987] softirqs last disabled at (327177): [] irq_exit+0x98/0xcc -- Murali Karicheri Linux Kernel, Keystone