All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Ahern <dsa@cumulusnetworks.com>
To: David Miller <davem@davemloft.net>
Cc: stephen@networkplumber.org, netdev@vger.kernel.org
Subject: Re: [iproute2 net-next] ip route: Add RTM_F_LOOKUP_TABLE flag and show table id
Date: Mon, 21 Sep 2015 16:23:13 -0600	[thread overview]
Message-ID: <56008351.7010005@cumulusnetworks.com> (raw)
In-Reply-To: <20150921.150346.926573540048522271.davem@davemloft.net>

On 9/21/15 4:03 PM, David Miller wrote:
> From: David Ahern <dsa@cumulusnetworks.com>
> Date: Mon, 21 Sep 2015 16:03:00 -0600
>
>> On 9/21/15 3:58 PM, David Miller wrote:
>>> I think if it always gave MAIN in older kernels, iproute should
>>> continue
>>> to do so.
>>>
>>> You can't just remove the table ID output just because you disagree
>>> with
>>> the semantics given by old kernels.
>>>
>>
>> Current semantics are maintained. Kernel was hardcoded to return main;
>> iproute2 was hardcoded to not show main.
>
> Since iproute2 always showed MAIN, it should conitnue to do so when
> run on older kernels.
>
> And again this is regardless of whether you disagree with those
> semantics or not.
>

Dave:

ip does *not* show the table id or string today:

root@vm-wheezy2:~# ip route get 10.2.1.254
10.2.1.254 dev eth1 src 10.2.1.2
cache


With the new flag a AND kernel that supports it ip will only show the 
table id IF it is not main:

root@vm-wheezy2:~# ./ip route get 10.0.0.20
10.0.0.20 dev eth0  src 10.0.0.2
     cache

root@vm-wheezy2:~# ./ip route get 10.2.1.254
10.2.1.254 dev eth1  table 10  src 10.2.1.2
     cache

That's my point. I have not changed existing users.

  reply	other threads:[~2015-09-21 22:23 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-21 18:19 [iproute2 net-next] ip route: Add RTM_F_LOOKUP_TABLE flag and show table id David Ahern
2015-09-21 21:19 ` Stephen Hemminger
2015-09-21 21:28   ` David Ahern
2015-09-21 21:58     ` David Miller
2015-09-21 22:03       ` David Ahern
2015-09-21 22:03         ` David Miller
2015-09-21 22:23           ` David Ahern [this message]
2015-09-21 22:36             ` David Miller
2015-09-23 23:14 ` Stephen Hemminger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56008351.7010005@cumulusnetworks.com \
    --to=dsa@cumulusnetworks.com \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.