From mboxrd@z Thu Jan  1 00:00:00 1970
From: Julien Grall <julien.grall@citrix.com>
Subject: Re: [PATCH v6 2/2] xen/arm: support gzip compressed
	kernels
Date: Tue, 22 Sep 2015 00:03:05 +0100
Message-ID: <56008CA9.7010209@citrix.com>
References: <alpine.DEB.2.02.1509212345200.2672@kaball.uk.xensource.com>
	<1442875893-21974-2-git-send-email-stefano.stabellini@eu.citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1442875893-21974-2-git-send-email-stefano.stabellini@eu.citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>, xen-devel@lists.xensource.com
Cc: Ian.Campbell@citrix.com
List-Id: xen-devel@lists.xenproject.org

Hi Stefano,

On 21/09/2015 23:51, Stefano Stabellini wrote:
> Changes in v6:
> - use vmap to map pages
> - free old module and update mod->start and mod->size from
> kernel_decompress

I was expecting you to drop my Reviewed-by given those changes.

> diff --git a/xen/arch/arm/kernel.c b/xen/arch/arm/kernel.c
> index f641b12..ad7e6bc 100644
> --- a/xen/arch/arm/kernel.c
> +++ b/xen/arch/arm/kernel.c

[...]


> +static __init uint32_t output_length(char *image, unsigned long image_len)
> +{
> +    return *(uint32_t *)&image[image_len - 4];
> +}
> +
> +static __init int kernel_decompress(struct bootmodule *mod)
> +{

[...]

> +    mfn = _mfn(page_to_mfn(pages));
> +    output = __vmap(&mfn, 1 << kernel_order_out, 1, 1, PAGE_HYPERVISOR);

You may want to use vmap here which is a wrapper to __vmap and will 
setup the granularity, align, and flags automatically for you.

Regards,

-- 
Julien Grall