From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jacek Anaszewski Subject: Re: [PATCH 30/38] leds: flash: remove invalid check Date: Tue, 22 Sep 2015 09:36:43 +0200 Message-ID: <5601050B.1000802@samsung.com> References: <1442842450-29769-1-git-send-email-a.hajda@samsung.com> <1442842450-29769-31-git-send-email-a.hajda@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from mailout3.w1.samsung.com ([210.118.77.13]:10840 "EHLO mailout3.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932340AbbIVHgr (ORCPT ); Tue, 22 Sep 2015 03:36:47 -0400 In-reply-to: <1442842450-29769-31-git-send-email-a.hajda@samsung.com> Sender: linux-leds-owner@vger.kernel.org List-Id: linux-leds@vger.kernel.org To: Andrzej Hajda Cc: linux-kernel@vger.kernel.org, Bartlomiej Zolnierkiewicz , Marek Szyprowski , Richard Purdie , linux-leds@vger.kernel.org Hi Andrzej, On 09/21/2015 03:34 PM, Andrzej Hajda wrote: > Unsigned cannot be lesser than zero. > > The problem has been detected using proposed semantic patch > scripts/coccinelle/tests/unsigned_lesser_than_zero.cocci [1]. > > [1]: http://permalink.gmane.org/gmane.linux.kernel/2038576 > > Signed-off-by: Andrzej Hajda > --- > drivers/leds/led-class-flash.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/leds/led-class-flash.c b/drivers/leds/led-class-flash.c > index 3b25734..c209077 100644 > --- a/drivers/leds/led-class-flash.c > +++ b/drivers/leds/led-class-flash.c > @@ -108,7 +108,7 @@ static ssize_t flash_strobe_store(struct device *dev, > if (ret) > goto unlock; > > - if (state < 0 || state > 1) { > + if (state > 1) { > ret = -EINVAL; > goto unlock; > } > Merged, thanks. -- Best Regards, Jacek Anaszewski