From: Julien Grall <julien.grall@citrix.com>
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: xen-devel@lists.xensource.com, Ian.Campbell@citrix.com
Subject: Re: [PATCH v6 2/2] xen/arm: support gzip compressed kernels
Date: Tue, 22 Sep 2015 10:04:44 +0100 [thread overview]
Message-ID: <560119AC.9080801@citrix.com> (raw)
In-Reply-To: <alpine.DEB.2.02.1509220234020.2672@kaball.uk.xensource.com>
Hi Stefano,
On 22/09/2015 02:35, Stefano Stabellini wrote:
>>> You may want to use vmap here which is a wrapper to __vmap and will setup the
>>> granularity, align, and flags automatically for you.
>>
>> The arguments are different.
Yes, sorry I inverted nr with granularity.
> I meant to say that it makes more sense to pass one region of higher granularity,
> than to map pages one by one.
Well, the page will still be mapped one by one in map_pages_to_xen one
by one because we don't support super-page mapping.
TBH if you care about performance, you would only map the strict
necessary because the smallest granularity to fit all the kernel may be
big compare to the real size.
For instance, if the decompress size is 65M, you would have to map 128M.
Anyway, it's only used during boot, so I don't much care if you use
__vmap. My suggestion was only for simplifying the code.
Regards,
--
Julien Grall
next prev parent reply other threads:[~2015-09-22 9:04 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-21 22:50 [PATCH v6 0/2] support gzipped kernels on arm Stefano Stabellini
2015-09-21 22:51 ` [PATCH v6 1/2] xen: move perform_gunzip to common Stefano Stabellini
2015-09-21 22:51 ` [PATCH v6 2/2] xen/arm: support gzip compressed kernels Stefano Stabellini
2015-09-21 23:03 ` Julien Grall
2015-09-22 1:22 ` Stefano Stabellini
2015-09-22 1:35 ` Stefano Stabellini
2015-09-22 9:04 ` Julien Grall [this message]
2015-09-22 9:08 ` Julien Grall
2015-09-22 22:18 ` Stefano Stabellini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=560119AC.9080801@citrix.com \
--to=julien.grall@citrix.com \
--cc=Ian.Campbell@citrix.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.