From mboxrd@z Thu Jan 1 00:00:00 1970 From: icenowy@aosc.xyz (Icenowy Zheng) Date: Wed, 27 Jul 2016 10:38:10 +0800 Subject: [PATCH v4] ARM: dts: sun8i: Add dts file for Olimex A33-OLinuXino In-Reply-To: <20160726153352.GH7190@lukather> References: <1469450243-19138-1-git-send-email-stefan.mavrodiev@gmail.com> <20160726153352.GH7190@lukather> Message-ID: <5601469587090@web14m.yandex.ru> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org 26.07.2016, 23:38, "Maxime Ripard" : > Hi Stefan, > > On Mon, Jul 25, 2016 at 03:37:23PM +0300, Stefan Mavrodiev wrote: >> ?A33-OLinuXino is A33 development board designed by Olimex LTD. >> >> ?It has AXP233 PMU, 1GB DRAM, a micro SD card, one USB-OTG connector, >> ?headphone and mic jacks, connector for LiPo battery and optional >> ?4GB NAND Flash. >> >> ?It has two 40-pin headers. One for LCD panel, and one for >> ?additional modules. Also there is CSI/DSI connector. >> >> ?Signed-off-by: Stefan Mavrodiev > > It looks mostly good, a few comments though. >> ?+&pio { >> ?+ led_pin_olinuxino: led_pins at 0 { >> ?+ allwinner,pins = "PB7"; >> ?+ allwinner,function = "gpio_out"; > > This line is not properly indented. > >> ?+ allwinner,drive = ; >> ?+ allwinner,pull = ; >> ?+ }; > > And this one too. > >> ?+®_dc1sw { >> ?+ regulator-name = "vcc-lcd"; >> ?+}; > > No constraints on this one? The "regulator" dc1sw is, in fact, a switch (so it's named as "sw"). So it have only on-off status. The constraints in dc1sw has prevented one of my A31s tablet from booting when it's not removed. > >> ?+®_dcdc1 { >> ?+ regulator-always-on; >> ?+ regulator-min-microvolt = <3300000>; >> ?+ regulator-max-microvolt = <3300000>; >> ?+ regulator-name = "vcc-dsi"; >> ?+}; > > What is it used for? Is it really necessary to keep it on at all time? > > Thanks, > Maxime > > -- > Maxime Ripard, Free Electrons > Embedded Linux and Kernel engineering > http://free-electrons.com > , > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel at lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 From: Icenowy Zheng Subject: Re: [PATCH v4] ARM: dts: sun8i: Add dts file for Olimex A33-OLinuXino Date: Wed, 27 Jul 2016 10:38:10 +0800 Message-ID: <5601469587090@web14m.yandex.ru> References: <1469450243-19138-1-git-send-email-stefan.mavrodiev@gmail.com> <20160726153352.GH7190@lukather> Reply-To: icenowy-ymACFijhrKM@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Return-path: Sender: linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org In-Reply-To: <20160726153352.GH7190@lukather> List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , To: Maxime Ripard , Stefan Mavrodiev Cc: "mark.rutland-5wv7dgnIgG8@public.gmane.org" , "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "pawel.moll-5wv7dgnIgG8@public.gmane.org" , "ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org" , "linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org" , "linux-I+IVW8TIWO2tmTQ+vhA3Yw@public.gmane.org" , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "wens-jdAy2FN1RRM@public.gmane.org" , "galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org" , "dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org" , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" List-Id: devicetree@vger.kernel.org 26.07.2016, 23:38, "Maxime Ripard" : > Hi Stefan, > > On Mon, Jul 25, 2016 at 03:37:23PM +0300, Stefan Mavrodiev wrote: >> =C2=A0A33-OLinuXino is A33 development board designed by Olimex LTD. >> >> =C2=A0It has AXP233 PMU, 1GB DRAM, a micro SD card, one USB-OTG connecto= r, >> =C2=A0headphone and mic jacks, connector for LiPo battery and optional >> =C2=A04GB NAND Flash. >> >> =C2=A0It has two 40-pin headers. One for LCD panel, and one for >> =C2=A0additional modules. Also there is CSI/DSI connector. >> >> =C2=A0Signed-off-by: Stefan Mavrodiev > > It looks mostly good, a few comments though. >> =C2=A0+&pio { >> =C2=A0+ led_pin_olinuxino: led_pins@0 { >> =C2=A0+ allwinner,pins =3D "PB7"; >> =C2=A0+ allwinner,function =3D "gpio_out"; > > This line is not properly indented. > >> =C2=A0+ allwinner,drive =3D ; >> =C2=A0+ allwinner,pull =3D ; >> =C2=A0+ }; > > And this one too. > >> =C2=A0+®_dc1sw { >> =C2=A0+ regulator-name =3D "vcc-lcd"; >> =C2=A0+}; > > No constraints on this one? The "regulator" dc1sw is, in fact, a switch (so it's named as "sw"). So it have only on-off status. The constraints in dc1sw has prevented one of my A31s tablet from booting when it's not removed. > >> =C2=A0+®_dcdc1 { >> =C2=A0+ regulator-always-on; >> =C2=A0+ regulator-min-microvolt =3D <3300000>; >> =C2=A0+ regulator-max-microvolt =3D <3300000>; >> =C2=A0+ regulator-name =3D "vcc-dsi"; >> =C2=A0+}; > > What is it used for? Is it really necessary to keep it on at all time? > > Thanks, > Maxime > > -- > Maxime Ripard, Free Electrons > Embedded Linux and Kernel engineering > http://free-electrons.com > , > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --=20 You received this message because you are subscribed to the Google Groups "= linux-sunxi" group. To unsubscribe from this group and stop receiving emails from it, send an e= mail to linux-sunxi+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org For more options, visit https://groups.google.com/d/optout.