From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrzej Hajda Date: Tue, 22 Sep 2015 12:55:09 +0000 Subject: Re: [patch] drm/layerscape: fix a signedness bug Message-Id: <56014FAD.7010805@samsung.com> List-Id: References: <20150922123104.GB27407@mwanda> In-Reply-To: <20150922123104.GB27407@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Dan Carpenter , Jianwei Wang Cc: kernel-janitors@vger.kernel.org, dri-devel@lists.freedesktop.org, Alison Wang Hi, I have posted the same patch yesterday [1]. http://permalink.gmane.org/gmane.comp.video.dri.devel/136945 Regards Andrzej On 09/22/2015 02:31 PM, Dan Carpenter wrote: > "index" needs to be signed for the error handling to work. Really "ret" > should be an int as well. > > Fixes: 109eee2f2a18 ('drm/layerscape: Add Freescale DCU DRM driver') > Signed-off-by: Dan Carpenter > > diff --git a/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_plane.c b/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_plane.c > index 82be6b8..d1e300d 100644 > --- a/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_plane.c > +++ b/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_plane.c > @@ -58,7 +58,8 @@ static void fsl_dcu_drm_plane_atomic_disable(struct drm_plane *plane, > struct drm_plane_state *old_state) > { > struct fsl_dcu_drm_device *fsl_dev = plane->dev->dev_private; > - unsigned int index, value, ret; > + unsigned int value; > + int index, ret; > > index = fsl_dcu_drm_plane_index(plane); > if (index < 0) > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/dri-devel > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrzej Hajda Subject: Re: [patch] drm/layerscape: fix a signedness bug Date: Tue, 22 Sep 2015 14:55:09 +0200 Message-ID: <56014FAD.7010805@samsung.com> References: <20150922123104.GB27407@mwanda> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mailout4.w1.samsung.com (mailout4.w1.samsung.com [210.118.77.14]) by gabe.freedesktop.org (Postfix) with ESMTPS id B6D0B6E69A for ; Tue, 22 Sep 2015 05:55:34 -0700 (PDT) Received: from eucpsbgm1.samsung.com (unknown [203.254.199.244]) by mailout4.w1.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTP id <0NV200JONX8JYC00@mailout4.w1.samsung.com> for dri-devel@lists.freedesktop.org; Tue, 22 Sep 2015 13:55:31 +0100 (BST) In-reply-to: <20150922123104.GB27407@mwanda> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Dan Carpenter , Jianwei Wang Cc: kernel-janitors@vger.kernel.org, dri-devel@lists.freedesktop.org, Alison Wang List-Id: dri-devel@lists.freedesktop.org SGksCgpJIGhhdmUgcG9zdGVkIHRoZSBzYW1lIHBhdGNoIHllc3RlcmRheSBbMV0uCgpodHRwOi8v cGVybWFsaW5rLmdtYW5lLm9yZy9nbWFuZS5jb21wLnZpZGVvLmRyaS5kZXZlbC8xMzY5NDUKClJl Z2FyZHMKQW5kcnplagoKT24gMDkvMjIvMjAxNSAwMjozMSBQTSwgRGFuIENhcnBlbnRlciB3cm90 ZToKPiAiaW5kZXgiIG5lZWRzIHRvIGJlIHNpZ25lZCBmb3IgdGhlIGVycm9yIGhhbmRsaW5nIHRv IHdvcmsuICBSZWFsbHkgInJldCIKPiBzaG91bGQgYmUgYW4gaW50IGFzIHdlbGwuCj4gCj4gRml4 ZXM6IDEwOWVlZTJmMmExOCAoJ2RybS9sYXllcnNjYXBlOiBBZGQgRnJlZXNjYWxlIERDVSBEUk0g ZHJpdmVyJykKPiBTaWduZWQtb2ZmLWJ5OiBEYW4gQ2FycGVudGVyIDxkYW4uY2FycGVudGVyQG9y YWNsZS5jb20+Cj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9mc2wtZGN1L2ZzbF9k Y3VfZHJtX3BsYW5lLmMgYi9kcml2ZXJzL2dwdS9kcm0vZnNsLWRjdS9mc2xfZGN1X2RybV9wbGFu ZS5jCj4gaW5kZXggODJiZTZiOC4uZDFlMzAwZCAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9k cm0vZnNsLWRjdS9mc2xfZGN1X2RybV9wbGFuZS5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2Zz bC1kY3UvZnNsX2RjdV9kcm1fcGxhbmUuYwo+IEBAIC01OCw3ICs1OCw4IEBAIHN0YXRpYyB2b2lk IGZzbF9kY3VfZHJtX3BsYW5lX2F0b21pY19kaXNhYmxlKHN0cnVjdCBkcm1fcGxhbmUgKnBsYW5l LAo+ICAJCQkJCSAgICAgc3RydWN0IGRybV9wbGFuZV9zdGF0ZSAqb2xkX3N0YXRlKQo+ICB7Cj4g IAlzdHJ1Y3QgZnNsX2RjdV9kcm1fZGV2aWNlICpmc2xfZGV2ID0gcGxhbmUtPmRldi0+ZGV2X3By aXZhdGU7Cj4gLQl1bnNpZ25lZCBpbnQgaW5kZXgsIHZhbHVlLCByZXQ7Cj4gKwl1bnNpZ25lZCBp bnQgdmFsdWU7Cj4gKwlpbnQgaW5kZXgsIHJldDsKPiAgCj4gIAlpbmRleCA9IGZzbF9kY3VfZHJt X3BsYW5lX2luZGV4KHBsYW5lKTsKPiAgCWlmIChpbmRleCA8IDApCj4gX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KPiBkcmktZGV2ZWwgbWFpbGluZyBsaXN0 Cj4gZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+IGh0dHA6Ly9saXN0cy5mcmVlZGVz a3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwKPiAKCl9fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJp LWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3Jn L21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg==