From: Paolo Bonzini <pbonzini@redhat.com>
To: Pavel Dovgalyuk <Pavel.Dovgaluk@ispras.ru>, qemu-devel@nongnu.org
Cc: edgar.iglesias@xilinx.com, peter.maydell@linaro.org,
igor.rubinov@gmail.com, alex.bennee@linaro.org,
mark.burton@greensocs.com, real@ispras.ru, batuzovk@ispras.ru,
maria.klimushenkova@ispras.ru, hines@cert.org,
fred.konrad@greensocs.com
Subject: Re: [Qemu-devel] [PATCH v18 11/21] replay: recording and replaying clock ticks
Date: Tue, 22 Sep 2015 15:15:10 +0200 [thread overview]
Message-ID: <5601545E.9090000@redhat.com> (raw)
In-Reply-To: <20150917162427.8676.36558.stgit@PASHA-ISP.def.inno>
On 17/09/2015 18:24, Pavel Dovgalyuk wrote:
> + if ((now < last || now > (last + get_max_clock_jump()))
> + && replay_mode == REPLAY_MODE_NONE) {
> notifier_list_notify(&clock->reset_notifiers, &now);
This seems wrong. You will have different timers in the record and the
replay if you do not invoke e.g. rtc_notify_clock_reset.
Paolo
next prev parent reply other threads:[~2015-09-22 13:15 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-17 16:23 [Qemu-devel] [PATCH v18 00/21] Deterministic replay core Pavel Dovgalyuk
2015-09-17 16:23 ` [Qemu-devel] [PATCH v18 01/21] i386: partial revert of interrupt poll fix Pavel Dovgalyuk
2015-09-17 16:23 ` [Qemu-devel] [PATCH v18 02/21] replay: global variables and function stubs Pavel Dovgalyuk
2015-09-17 16:23 ` [Qemu-devel] [PATCH v18 03/21] replay: internal functions for replay log Pavel Dovgalyuk
2015-09-17 16:23 ` [Qemu-devel] [PATCH v18 04/21] replay: introduce mutex to protect the " Pavel Dovgalyuk
2015-09-17 16:23 ` [Qemu-devel] [PATCH v18 05/21] replay: introduce icount event Pavel Dovgalyuk
2015-09-17 16:23 ` [Qemu-devel] [PATCH v18 06/21] cpu-exec: allow temporary disabling icount Pavel Dovgalyuk
2015-09-17 16:24 ` [Qemu-devel] [PATCH v18 07/21] cpu: replay instructions sequence Pavel Dovgalyuk
2015-09-17 16:24 ` [Qemu-devel] [PATCH v18 08/21] i386: interrupt poll processing Pavel Dovgalyuk
2015-09-17 16:24 ` [Qemu-devel] [PATCH v18 09/21] replay: interrupts and exceptions Pavel Dovgalyuk
2015-09-17 16:24 ` [Qemu-devel] [PATCH v18 10/21] replay: asynchronous events infrastructure Pavel Dovgalyuk
2015-09-17 16:24 ` [Qemu-devel] [PATCH v18 11/21] replay: recording and replaying clock ticks Pavel Dovgalyuk
2015-09-22 13:15 ` Paolo Bonzini [this message]
2015-09-23 7:09 ` Pavel Dovgaluk
2015-09-17 16:24 ` [Qemu-devel] [PATCH v18 12/21] replay: shutdown event Pavel Dovgalyuk
2015-09-17 16:24 ` [Qemu-devel] [PATCH v18 13/21] icount: improve counting for record/replay Pavel Dovgalyuk
2015-09-22 13:15 ` Paolo Bonzini
2015-09-23 7:22 ` Pavel Dovgaluk
[not found] ` <1946.37127356163$1442992987@news.gmane.org>
2015-09-23 8:08 ` Paolo Bonzini
2015-09-23 8:42 ` Pavel Dovgaluk
2015-09-17 16:24 ` [Qemu-devel] [PATCH v18 14/21] replay: checkpoints Pavel Dovgalyuk
2015-09-17 16:24 ` [Qemu-devel] [PATCH v18 15/21] bottom halves: introduce bh call function Pavel Dovgalyuk
2015-09-17 16:24 ` [Qemu-devel] [PATCH v18 16/21] replay: ptimer Pavel Dovgalyuk
2015-09-17 16:25 ` [Qemu-devel] [PATCH v18 17/21] typedef: add typedef for QemuOpts Pavel Dovgalyuk
2015-09-17 16:25 ` [Qemu-devel] [PATCH v18 18/21] replay: initialization and deinitialization Pavel Dovgalyuk
2015-09-17 16:25 ` [Qemu-devel] [PATCH v18 19/21] replay: replay blockers for devices Pavel Dovgalyuk
2015-10-06 20:15 ` Eric Blake
2015-09-17 16:25 ` [Qemu-devel] [PATCH v18 20/21] replay: command line options Pavel Dovgalyuk
2015-09-17 16:25 ` [Qemu-devel] [PATCH v18 21/21] replay: recording of the user input Pavel Dovgalyuk
2015-09-21 7:12 ` [Qemu-devel] [PATCH v18 00/21] Deterministic replay core Pavel Dovgaluk
2015-09-22 13:13 ` Paolo Bonzini
[not found] ` <13403.5645904534$1442819578@news.gmane.org>
2015-10-06 15:09 ` Paolo Bonzini
2015-10-06 16:38 ` Paolo Bonzini
[not found] ` <CAPnv1P+PMm7stf-TUoWBX9+frHHOWzz=LB-Errn6_=fBO_QxNQ@mail.gmail.com>
[not found] ` <CAPnv1PKaYDZQeMxK33e1U3mWcsNQiufPnDxLZgiFxXAktxzktA@mail.gmail.com>
2015-11-04 10:57 ` Igor R
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5601545E.9090000@redhat.com \
--to=pbonzini@redhat.com \
--cc=Pavel.Dovgaluk@ispras.ru \
--cc=alex.bennee@linaro.org \
--cc=batuzovk@ispras.ru \
--cc=edgar.iglesias@xilinx.com \
--cc=fred.konrad@greensocs.com \
--cc=hines@cert.org \
--cc=igor.rubinov@gmail.com \
--cc=maria.klimushenkova@ispras.ru \
--cc=mark.burton@greensocs.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=real@ispras.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.