From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33919) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZeP2l-0003ug-Vz for qemu-devel@nongnu.org; Tue, 22 Sep 2015 10:59:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZeP2i-0004k8-Kc for qemu-devel@nongnu.org; Tue, 22 Sep 2015 10:59:43 -0400 Received: from lhrrgout.huawei.com ([194.213.3.17]:36013) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZeP2i-0004jh-3H for qemu-devel@nongnu.org; Tue, 22 Sep 2015 10:59:40 -0400 References: <1442333283-13119-1-git-send-email-marcandre.lureau@redhat.com> <1442333283-13119-45-git-send-email-marcandre.lureau@redhat.com> From: Claudio Fontana Message-ID: <56016CD9.4030703@huawei.com> Date: Tue, 22 Sep 2015 16:59:37 +0200 MIME-Version: 1.0 In-Reply-To: <1442333283-13119-45-git-send-email-marcandre.lureau@redhat.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH v3 44/46] ivshmem: remove EventfdEntry.vector List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: marcandre.lureau@redhat.com, qemu-devel@nongnu.org Cc: drjones@redhat.com, cam@cs.ualberta.ca, stefanha@redhat.com On 15.09.2015 18:08, marcandre.lureau@redhat.com wrote: > From: Marc-André Lureau > > No need to store an extra int for the vector number when it can be > computed easily by looking at the position in the array. > > Signed-off-by: Marc-André Lureau This one does not seem particularly valuable to me.. btw isn't it slightly easier to debug with the vector in the structure? > --- > hw/misc/ivshmem.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/hw/misc/ivshmem.c b/hw/misc/ivshmem.c > index ac90f0a..976fbea 100644 > --- a/hw/misc/ivshmem.c > +++ b/hw/misc/ivshmem.c > @@ -68,7 +68,6 @@ typedef struct Peer { > > typedef struct EventfdEntry { > PCIDevice *pdev; > - int vector; > } EventfdEntry; > > typedef struct IVShmemState { > @@ -287,9 +286,11 @@ static void fake_irqfd(void *opaque, const uint8_t *buf, int size) { > > EventfdEntry *entry = opaque; > PCIDevice *pdev = entry->pdev; > + IVShmemState *s = IVSHMEM(pdev); > + int vector = entry - s->eventfd_table; > > - IVSHMEM_DPRINTF("interrupt on vector %p %d\n", pdev, entry->vector); > - msix_notify(pdev, entry->vector); > + IVSHMEM_DPRINTF("interrupt on vector %p %d\n", pdev, vector); > + msix_notify(pdev, vector); > } > > static CharDriverState* create_eventfd_chr_device(void * opaque, EventNotifier *n, > @@ -311,7 +312,6 @@ static CharDriverState* create_eventfd_chr_device(void * opaque, EventNotifier * > /* if MSI is supported we need multiple interrupts */ > if (ivshmem_has_feature(s, IVSHMEM_MSI)) { > s->eventfd_table[vector].pdev = PCI_DEVICE(s); > - s->eventfd_table[vector].vector = vector; > > qemu_chr_add_handlers(chr, ivshmem_can_receive, fake_irqfd, > ivshmem_event, &s->eventfd_table[vector]); >