From: Guenter Roeck <linux@roeck-us.net>
To: Neil Armstrong <narmstrong@baylibre.com>,
"David S. Miller" <davem@davemloft.net>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: dsa: Fix Marvell Egress Trailer check
Date: Tue, 22 Sep 2015 08:12:06 -0700 [thread overview]
Message-ID: <56016FC6.9030503@roeck-us.net> (raw)
In-Reply-To: <56011F2E.5080208@baylibre.com>
On 09/22/2015 02:28 AM, Neil Armstrong wrote:
> The Marvell Egress rx trailer check must be fixed to
> correctly detect bad bits in the third byte of the
> Eggress trailer as described in the Table 28 of the
> 88E6060 datasheet.
> The current code incorrectly omits to check the third
> byte and checks the fourth byte twice.
>
> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
Nice catch.
Acked-by: Guenter Roeck <linux@roeck-us.net>
> ---
> net/dsa/tag_trailer.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/dsa/tag_trailer.c b/net/dsa/tag_trailer.c
> index e268f9d..d0526a9 100644
> --- a/net/dsa/tag_trailer.c
> +++ b/net/dsa/tag_trailer.c
> @@ -84,7 +84,7 @@ static int trailer_rcv(struct sk_buff *skb, struct net_device *dev,
>
> trailer = skb_tail_pointer(skb) - 4;
> if (trailer[0] != 0x80 || (trailer[1] & 0xf8) != 0x00 ||
> - (trailer[3] & 0xef) != 0x00 || trailer[3] != 0x00)
> + (trailer[2] & 0xef) != 0x00 || trailer[3] != 0x00)
> goto out_drop;
>
> source_port = trailer[1] & 7;
>
next prev parent reply other threads:[~2015-09-22 15:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-22 9:28 [PATCH] net: dsa: Fix Marvell Egress Trailer check Neil Armstrong
2015-09-22 15:12 ` Guenter Roeck [this message]
2015-09-23 0:37 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56016FC6.9030503@roeck-us.net \
--to=linux@roeck-us.net \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=narmstrong@baylibre.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.