From mboxrd@z Thu Jan 1 00:00:00 1970 From: nsekhar@ti.com (Sekhar Nori) Date: Tue, 22 Sep 2015 20:57:52 +0530 Subject: [PATCH] ARM: davinci: clock: Correct return values for API functions In-Reply-To: <1442222979-9703-1-git-send-email-peter.ujfalusi@ti.com> References: <1442222979-9703-1-git-send-email-peter.ujfalusi@ti.com> Message-ID: <56017378.5060503@ti.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Monday 14 September 2015 02:59 PM, Peter Ujfalusi wrote: > Fix the values returned by the publicly used functions. > These function should return 0 when they are called with clk == NULL in > similar manner as the clock API does to avoid different behavior in drivers > used by daVinci and other architectures. > > Signed-off-by: Peter Ujfalusi > --- > Hi Sekhar, > > This issue is visible when using generic drivers like ASoC simnple card for > audio support. > They rely on the fact that these functions will not return with error in case > of clk == NULL. Looks good. Will queue for v4.4. Some of the information below the tear line could go into the commit text too, I think. Thanks, Sekhar From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758206AbbIVP2X (ORCPT ); Tue, 22 Sep 2015 11:28:23 -0400 Received: from bear.ext.ti.com ([192.94.94.41]:41691 "EHLO bear.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751262AbbIVP2V (ORCPT ); Tue, 22 Sep 2015 11:28:21 -0400 Message-ID: <56017378.5060503@ti.com> Date: Tue, 22 Sep 2015 20:57:52 +0530 From: Sekhar Nori User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0 MIME-Version: 1.0 To: Peter Ujfalusi CC: , , Subject: Re: [PATCH] ARM: davinci: clock: Correct return values for API functions References: <1442222979-9703-1-git-send-email-peter.ujfalusi@ti.com> In-Reply-To: <1442222979-9703-1-git-send-email-peter.ujfalusi@ti.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Monday 14 September 2015 02:59 PM, Peter Ujfalusi wrote: > Fix the values returned by the publicly used functions. > These function should return 0 when they are called with clk == NULL in > similar manner as the clock API does to avoid different behavior in drivers > used by daVinci and other architectures. > > Signed-off-by: Peter Ujfalusi > --- > Hi Sekhar, > > This issue is visible when using generic drivers like ASoC simnple card for > audio support. > They rely on the fact that these functions will not return with error in case > of clk == NULL. Looks good. Will queue for v4.4. Some of the information below the tear line could go into the commit text too, I think. Thanks, Sekhar