From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55368) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZeQ2F-0007bK-Lk for qemu-devel@nongnu.org; Tue, 22 Sep 2015 12:03:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZeQ2A-0002Ay-OW for qemu-devel@nongnu.org; Tue, 22 Sep 2015 12:03:15 -0400 Received: from mx1.redhat.com ([209.132.183.28]:50395) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZeQ2A-0002At-Jc for qemu-devel@nongnu.org; Tue, 22 Sep 2015 12:03:10 -0400 References: <1442889976-8733-1-git-send-email-famz@redhat.com> <1442889976-8733-12-git-send-email-famz@redhat.com> From: Eric Blake Message-ID: <56017BB8.6040000@redhat.com> Date: Tue, 22 Sep 2015 10:03:04 -0600 MIME-Version: 1.0 In-Reply-To: <1442889976-8733-12-git-send-email-famz@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="N9cceSRpt50e6OmTeq06CV8mCtuoOt4kL" Subject: Re: [Qemu-devel] [PATCH v7 11/14] block/backup: support block job transactions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng , qemu-devel@nongnu.org Cc: Kevin Wolf , Jeff Cody , Max Reitz , vsementsov@parallels.com, stefanha@redhat.com, John Snow This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --N9cceSRpt50e6OmTeq06CV8mCtuoOt4kL Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 09/21/2015 08:46 PM, Fam Zheng wrote: > From: Stefan Hajnoczi >=20 > Join the transaction when the 'transactional-cancel' QMP argument is > true. >=20 > This ensures that the sync bitmap is not thrown away if another block > job in the transaction is cancelled or fails. This is critical so > incremental backup with multiple disks can be retried in case of > cancellation/failure. >=20 > Signed-off-by: Stefan Hajnoczi > Reviewed-by: Max Reitz > Reviewed-by: Eric Blake > Signed-off-by: Fam Zheng > --- > +++ b/qapi/block-core.json > @@ -735,7 +735,6 @@ > # @on-target-error: #optional the action to take on an error on the ta= rget, > # default 'report' (no limitations, since this appli= es to > # a different block device than @device). > -# > # Note that @on-source-error and @on-target-error only affect backgrou= nd I/O. > # If an error occurs during a guest write request, the device's rerror= /werror > # actions will be used. Spurious line deletion when addressing review comment. Maintainer can touch it up for the pull request, so my R-b still stands. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --N9cceSRpt50e6OmTeq06CV8mCtuoOt4kL Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWAXu4AAoJEKeha0olJ0NqAUEH/2BZ82O3fQLS1mR1ikRbHZ5K KQi0ZLgZUAGqwh7oo5xO2FQ8HyFQIeUhvxAJ12vZ+UzB1dkS5gCF+ZagZmvlreDG RvkW4rhixcFGuFSxGDmtya+cp8PR3AnokbRn2lCo0mAdWEwGLTwN8ycMKGN86tHn JxtSf91fHUhHshVSUp1Orp5+HduK6wzyFA/e5yoQlzA1omHgB/pj6dV6jYQ6Av+d y68+iwt/+gEl64piwNqKFLHST+bzCgDfKC07Oao7aRc5Sios9HkCNlX5fETnA8Po gr9i6+sStF/mugHC40wpDL9b+DLTcbBSvy6exUUkrTIwjJCcdlMazOQYT2jrwdw= =ifms -----END PGP SIGNATURE----- --N9cceSRpt50e6OmTeq06CV8mCtuoOt4kL--