From: Krzysztof Opasiak <k.opasiak@samsung.com>
To: balbi@ti.com, gregkh@linuxfoundation.org
Cc: linux-usb@vger.kernel.org, andrzej.p@samsung.com, stable@vger.kernel.org
Subject: Re: [PATCH v2 2/2] usb: gadget: loopback: Fix looping back logic implementation
Date: Tue, 22 Sep 2015 20:16:58 +0200 [thread overview]
Message-ID: <56019B1A.7030306@samsung.com> (raw)
In-Reply-To: <1442941006-16595-2-git-send-email-k.opasiak@samsung.com>
On 09/22/2015 06:56 PM, Krzysztof Opasiak wrote:
> Since:
>
> commit e0857ce58e8658657f5f12fe25272b93cfeb16aa
> ("usb: gadget: loopback: don't queue requests to bogus endpoints")
>
> Loopback function is not realy working as that commit removed
> all looping back logic. After that commit ep-out works like
> /dev/null and ep-in works like /dev/zero.
>
> This commit fix this issue by allocating set of out requests
> and set of in requests but each out req shares buffer with
> one in req:
>
> out_req->buf ---> buf <--- in_req.buf
> out_req->context <---> in_req.context
>
> The completion routine simply enqueue the suitable req in
> an oposite direction.
>
> Cc: <stable@vger.kernel.org> # 3.18+
> Signed-off-by: Krzysztof Opasiak <k.opasiak@samsung.com>
> ---
> Changes since v1:
> - add missing usb_ep_free_request() in complete() callback
After hour of using this I have faced some problem with memory feeing. I
will look for it and send update shortly.
--
Krzysztof Opasiak
Samsung R&D Institute Poland
Samsung Electronics
next prev parent reply other threads:[~2015-09-22 18:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-22 16:56 [PATCH v2 1/2] usb: gadget: loopback: fix: Don't share qlen and buflen between instances Krzysztof Opasiak
2015-09-22 16:56 ` [PATCH v2 2/2] usb: gadget: loopback: Fix looping back logic implementation Krzysztof Opasiak
2015-09-22 18:16 ` Krzysztof Opasiak [this message]
-- strict thread matches above, loose matches on Subject: below --
2015-09-22 16:54 [PATCH v2 1/2] usb: gadget: loopback: fix: Don't share qlen and buflen between instances Krzysztof Opasiak
2015-09-22 16:54 ` [PATCH v2 2/2] usb: gadget: loopback: Fix looping back logic implementation Krzysztof Opasiak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56019B1A.7030306@samsung.com \
--to=k.opasiak@samsung.com \
--cc=andrzej.p@samsung.com \
--cc=balbi@ti.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-usb@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.