From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx2.suse.de ([195.135.220.15]:59308 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751500AbbIVU1g (ORCPT ); Tue, 22 Sep 2015 16:27:36 -0400 Subject: Re: [RFT v3] eata: Convert eata driver as normal PCI and platform device drivers To: Jiang Liu , Thomas Gleixner , Bjorn Helgaas , Arthur Marsh , Ballabio Dario , Christoph Hellwig , Dario Ballabio , "James E.J. Bottomley" References: <20150916134211.GA21535@infradead.org> <1442907023-12709-1-git-send-email-jiang.liu@linux.intel.com> Cc: linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, linux-scsi@vger.kernel.org, x86@kernel.org From: Hannes Reinecke Message-ID: <5601B9B0.4090302@suse.de> Date: Tue, 22 Sep 2015 22:27:28 +0200 MIME-Version: 1.0 In-Reply-To: <1442907023-12709-1-git-send-email-jiang.liu@linux.intel.com> Content-Type: text/plain; charset=windows-1252 Sender: linux-pci-owner@vger.kernel.org List-ID: On 09/22/2015 09:30 AM, Jiang Liu wrote: > Previously the eata driver just grabs and accesses eata PCI devices > without implementing a PCI device driver, that causes troubles with > latest IRQ related > > Commit 991de2e59090 ("PCI, x86: Implement pcibios_alloc_irq() and > pcibios_free_irq()") changes the way to allocate PCI legacy IRQ > for PCI devices on x86 platforms. Instead of allocating PCI legacy > IRQs when pcibios_enable_device() gets called, now pcibios_alloc_irq() > will be called by pci_device_probe() to allocate PCI legacy IRQs > when binding PCI drivers to PCI devices. > > But the eata driver directly accesses PCI devices without implementing > corresponding PCI drivers, so pcibios_alloc_irq() won't be called for > those PCI devices and wrong IRQ number may be used to manage the PCI > device. > > This patch implements a PCI device driver to manage eata PCI devices, > so eata driver could properly cooperate with the PCI core. It also > provides headroom for PCI hotplug with eata driver. > > It also represents non-PCI eata devices as platform devices, so it could > be managed as normal devices. > > Signed-off-by: Jiang Liu > Cc: Hannes Reinecke > Cc: Ballabio, Dario > Cc: Christoph Hellwig Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage hare@suse.de +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)