Re: [Qemu-devel] [Qemu-block] [PULL 2/8] hmp: Allow for error message hints on HMP

[John Snow <jsnow@redhat.com>]

On 09/22/2015 01:02 PM, Eric Blake wrote:
> On 09/22/2015 09:23 AM, Kevin Wolf wrote:
>> Am 18.09.2015 um 15:22 hat Markus Armbruster geschrieben:
>>> From: Eric Blake <eblake@redhat.com>
>>>
>>> Commits 7216ae3d and d2828429 disabled some error message hints,
>>> all because a change to use modern error reporting meant that the
>>> hint would be output prior to the actual error.  Fix this by making
>>> hints a first-class member of Error.
>>>
>>> For example, we are now back to the pleasant:
>>>
>>>  $ qemu-system-x86_64 --nodefaults -S --vnc :0 --chardev null,id=,
>>>  qemu-system-x86_64: --chardev null,id=,: Parameter 'id' expects an identifier
>>>  Identifiers consist of letters, digits, '-', '.', '_', starting with a letter.
>>>
>>> Signed-off-by: Eric Blake <eblake@redhat.com>
>>> Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
>>> Message-Id: <1441901956-21991-1-git-send-email-eblake@redhat.com>
>>> Signed-off-by: Markus Armbruster <armbru@redhat.com>
>>
>> This broke qemu-iotests 049. Can you please send a patch to update the
>> reference output?
> 
> Will do (and I guess I should run qemu-iotests more frequently. Does
> 'make check' suffice, or is there other magic involved?)
> 

>From the build directory:

pushd tests/qemu-iotests;
./check -v -qcow2;
./check -v -raw;
popd

If there is a smarter way of doing it, it is unknown to me.

--js