All of lore.kernel.org
 help / color / mirror / Atom feed
From: John Snow <jsnow@redhat.com>
To: Eric Blake <eblake@redhat.com>, qemu-devel@nongnu.org
Cc: kwolf@redhat.com, armbru@redhat.com, qemu-block@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] tests: Fix test 049 fallout from improved HMP error messages
Date: Tue, 22 Sep 2015 19:23:26 -0400	[thread overview]
Message-ID: <5601E2EE.8010109@redhat.com> (raw)
In-Reply-To: <1442963752-10950-1-git-send-email-eblake@redhat.com>



On 09/22/2015 07:15 PM, Eric Blake wrote:
> Commit 50b7b000 improved HMP error messages, but forgot to update
> qemu-iotests to match.
> 
> Reported-by: Kevin Wolf <kwolf@redhat.com>
> Signed-off-by: Eric Blake <eblake@redhat.com>
> ---
> 
> I'm not sure if this should go through Markus' "error" tree,
> since that's where the break was introduced, or through a
> "block" tree since it touches qemu-iotests.
> 
> And now that I have a recipe for running qemu-iotests, I should
> have no excuse for repeating this type of mistake :)
> 
>  tests/qemu-iotests/049.out | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/tests/qemu-iotests/049.out b/tests/qemu-iotests/049.out
> index 0425ae0..a2b6703 100644
> --- a/tests/qemu-iotests/049.out
> +++ b/tests/qemu-iotests/049.out
> @@ -118,6 +118,7 @@ qemu-img: kilobytes, megabytes, gigabytes, terabytes, petabytes and exabytes.
> 
>  qemu-img create -f qcow2 -o size=foobar TEST_DIR/t.qcow2
>  qemu-img: Parameter 'size' expects a size
> +You may use k, M, G or T suffixes for kilobytes, megabytes, gigabytes and terabytes.
>  qemu-img: TEST_DIR/t.qcow2: Invalid options for file format 'qcow2'
> 
>  == Check correct interpretation of suffixes for cluster size ==
> 

Grazie,

Reviewed-by: John Snow <jsnow@redhat.com>

  reply	other threads:[~2015-09-22 23:23 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-22 23:15 [Qemu-devel] [PATCH] tests: Fix test 049 fallout from improved HMP error messages Eric Blake
2015-09-22 23:23 ` John Snow [this message]
2015-09-24  9:38 ` [Qemu-devel] [Qemu-block] " Alberto Garcia
2015-09-24  9:53 ` [Qemu-devel] " Kevin Wolf
2015-09-24 11:59   ` Markus Armbruster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5601E2EE.8010109@redhat.com \
    --to=jsnow@redhat.com \
    --cc=armbru@redhat.com \
    --cc=eblake@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.