From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from szxga01-in.huawei.com ([58.251.152.64]:64003 "EHLO szxga01-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752177AbbIWD2K (ORCPT ); Tue, 22 Sep 2015 23:28:10 -0400 Message-ID: <56021BC4.9030000@hisilicon.com> Date: Wed, 23 Sep 2015 11:25:56 +0800 From: Zhou Wang MIME-Version: 1.0 To: Pratyush Anand CC: Bjorn Helgaas , Jingoo Han , Arnd Bergmann , Russell King - ARM Linux , Thomas Petazzoni , Gabriele Paoloni , , James Morse , Liviu Dudau , Jason Cooper , , Gabriel Fernandez , Minghuan Lian , "linux-pci@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "devicetree@vger.kernel.org" , Zhang Jukuo , , , , , Liguozhu Subject: Re: [PATCH v9 3/6] PCI: designware: Add ARM64 support References: <1442321361-174300-1-git-send-email-wangzhou1@hisilicon.com> <1442321361-174300-4-git-send-email-wangzhou1@hisilicon.com> <5600C285.5090603@hisilicon.com> In-Reply-To: Content-Type: text/plain; charset="UTF-8" Sender: linux-pci-owner@vger.kernel.org List-ID: On 2015/9/23 1:05, Pratyush Anand wrote: > Hi Zhou, > > On Tue, Sep 22, 2015 at 8:22 AM, Zhou Wang wrote: >> On 2015/9/15 20:49, Zhou Wang wrote: >>> This patch tries to unify ARM32 and ARM64 PCIe in designware driver. Delete >>> function dw_pcie_setup, dw_pcie_scan_bus, dw_pcie_map_irq and struct hw_pci, >>> move related operations to dw_pcie_host_init. >>> >>> This patch also try to use of_pci_get_host_bridge_resources for ARM32 and ARM64 >>> according to the suggestion for Gabriele[1] >>> >>> This patch reverts commit f4c55c5a3f7f ("PCI: designware: Program ATU with >>> untranslated address") based on 1/6 in this series. we delete *_mod_base in >>> pcie-designware. This was discussed in [2] >>> >>> I have compiled the driver with multi_v7_defconfig. However, I don't have >>> ARM32 PCIe related board to do test. It will be appreciated if someone could >>> help to test it. >>> >>> Signed-off-by: Zhou Wang >>> Signed-off-by: Gabriele Paoloni >>> Signed-off-by: Arnd Bergmann >>> Tested-by: James Morse >>> Tested-by: Gabriel Fernandez >>> Tested-by: Minghuan Lian > > Sorry for delayed response. Since I moved from ST, I do not have any > test board having designware PCIe controller :(, and also I do > designware work only in my hobby time, so it took time to understand > few modifications. Anyway, all modifications looks fine to me. So, > > Acked-by: Pratyush Anand Hi Pratyush, Many thanks for your reviewing :) Best Regards, Zhou > > PS: Does someone know about a economical test board from any vendor > with designware PCIe IP? > -- > To unsubscribe from this list: send the line "unsubscribe linux-pci" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > > . > From mboxrd@z Thu Jan 1 00:00:00 1970 From: wangzhou1@hisilicon.com (Zhou Wang) Date: Wed, 23 Sep 2015 11:25:56 +0800 Subject: [PATCH v9 3/6] PCI: designware: Add ARM64 support In-Reply-To: References: <1442321361-174300-1-git-send-email-wangzhou1@hisilicon.com> <1442321361-174300-4-git-send-email-wangzhou1@hisilicon.com> <5600C285.5090603@hisilicon.com> Message-ID: <56021BC4.9030000@hisilicon.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 2015/9/23 1:05, Pratyush Anand wrote: > Hi Zhou, > > On Tue, Sep 22, 2015 at 8:22 AM, Zhou Wang wrote: >> On 2015/9/15 20:49, Zhou Wang wrote: >>> This patch tries to unify ARM32 and ARM64 PCIe in designware driver. Delete >>> function dw_pcie_setup, dw_pcie_scan_bus, dw_pcie_map_irq and struct hw_pci, >>> move related operations to dw_pcie_host_init. >>> >>> This patch also try to use of_pci_get_host_bridge_resources for ARM32 and ARM64 >>> according to the suggestion for Gabriele[1] >>> >>> This patch reverts commit f4c55c5a3f7f ("PCI: designware: Program ATU with >>> untranslated address") based on 1/6 in this series. we delete *_mod_base in >>> pcie-designware. This was discussed in [2] >>> >>> I have compiled the driver with multi_v7_defconfig. However, I don't have >>> ARM32 PCIe related board to do test. It will be appreciated if someone could >>> help to test it. >>> >>> Signed-off-by: Zhou Wang >>> Signed-off-by: Gabriele Paoloni >>> Signed-off-by: Arnd Bergmann >>> Tested-by: James Morse >>> Tested-by: Gabriel Fernandez >>> Tested-by: Minghuan Lian > > Sorry for delayed response. Since I moved from ST, I do not have any > test board having designware PCIe controller :(, and also I do > designware work only in my hobby time, so it took time to understand > few modifications. Anyway, all modifications looks fine to me. So, > > Acked-by: Pratyush Anand Hi Pratyush, Many thanks for your reviewing :) Best Regards, Zhou > > PS: Does someone know about a economical test board from any vendor > with designware PCIe IP? > -- > To unsubscribe from this list: send the line "unsubscribe linux-pci" in > the body of a message to majordomo at vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > > . > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Zhou Wang Subject: Re: [PATCH v9 3/6] PCI: designware: Add ARM64 support Date: Wed, 23 Sep 2015 11:25:56 +0800 Message-ID: <56021BC4.9030000@hisilicon.com> References: <1442321361-174300-1-git-send-email-wangzhou1@hisilicon.com> <1442321361-174300-4-git-send-email-wangzhou1@hisilicon.com> <5600C285.5090603@hisilicon.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-pci-owner@vger.kernel.org To: Pratyush Anand Cc: Bjorn Helgaas , Jingoo Han , Arnd Bergmann , Russell King - ARM Linux , Thomas Petazzoni , Gabriele Paoloni , lorenzo.pieralisi@arm.com, James Morse , Liviu Dudau , Jason Cooper , robh@kernel.org, Gabriel Fernandez , Minghuan Lian , "linux-pci@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "devicetree@vger.kernel.org" , Zhang Jukuo , qiuzhenfa@hisilicon.com, liudongdong3@huawei.com, qiujiang@huawei.com, xuwei5@hisilicon.com, Liguozhu List-Id: devicetree@vger.kernel.org On 2015/9/23 1:05, Pratyush Anand wrote: > Hi Zhou, > > On Tue, Sep 22, 2015 at 8:22 AM, Zhou Wang wrote: >> On 2015/9/15 20:49, Zhou Wang wrote: >>> This patch tries to unify ARM32 and ARM64 PCIe in designware driver. Delete >>> function dw_pcie_setup, dw_pcie_scan_bus, dw_pcie_map_irq and struct hw_pci, >>> move related operations to dw_pcie_host_init. >>> >>> This patch also try to use of_pci_get_host_bridge_resources for ARM32 and ARM64 >>> according to the suggestion for Gabriele[1] >>> >>> This patch reverts commit f4c55c5a3f7f ("PCI: designware: Program ATU with >>> untranslated address") based on 1/6 in this series. we delete *_mod_base in >>> pcie-designware. This was discussed in [2] >>> >>> I have compiled the driver with multi_v7_defconfig. However, I don't have >>> ARM32 PCIe related board to do test. It will be appreciated if someone could >>> help to test it. >>> >>> Signed-off-by: Zhou Wang >>> Signed-off-by: Gabriele Paoloni >>> Signed-off-by: Arnd Bergmann >>> Tested-by: James Morse >>> Tested-by: Gabriel Fernandez >>> Tested-by: Minghuan Lian > > Sorry for delayed response. Since I moved from ST, I do not have any > test board having designware PCIe controller :(, and also I do > designware work only in my hobby time, so it took time to understand > few modifications. Anyway, all modifications looks fine to me. So, > > Acked-by: Pratyush Anand Hi Pratyush, Many thanks for your reviewing :) Best Regards, Zhou > > PS: Does someone know about a economical test board from any vendor > with designware PCIe IP? > -- > To unsubscribe from this list: send the line "unsubscribe linux-pci" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > > . >