From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:51929)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <wency@cn.fujitsu.com>) id 1ZedQa-0003Bq-S0
	for qemu-devel@nongnu.org; Wed, 23 Sep 2015 02:21:17 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <wency@cn.fujitsu.com>) id 1ZedQX-0001RU-9T
	for qemu-devel@nongnu.org; Wed, 23 Sep 2015 02:21:16 -0400
References: <1442589793-7105-1-git-send-email-mreitz@redhat.com>
	<20150922144507.GH3999@noname.str.redhat.com>
	<56016F18.3030208@redhat.com>
From: Wen Congyang <wency@cn.fujitsu.com>
Message-ID: <560244B7.2020103@cn.fujitsu.com>
Date: Wed, 23 Sep 2015 14:20:39 +0800
MIME-Version: 1.0
In-Reply-To: <56016F18.3030208@redhat.com>
Content-Type: text/plain; charset="windows-1252"
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v5 00/38] blockdev: BlockBackend and media
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Max Reitz <mreitz@redhat.com>, Kevin Wolf <kwolf@redhat.com>
Cc: Alberto Garcia <berto@igalia.com>, qemu-block@nongnu.org, John Snow <jsnow@redhat.com>, qemu-devel@nongnu.org, Markus Armbruster <armbru@redhat.com>, Stefan Hajnoczi <stefanha@redhat.com>

On 09/22/2015 11:09 PM, Max Reitz wrote:
> On 22.09.2015 16:45, Kevin Wolf wrote:
>> Am 18.09.2015 um 17:22 hat Max Reitz geschrieben:
>>> This series reworks a lot regarding BlockBackend and media. Basically,
>>> it allows empty BlockBackends, that is BBs without a BDS tree.
>>>
>>> Before this series, empty drives are represented by a BlockBackend with
>>> an empty BDS attached to it (a BDS with a NULL driver). However, now we
>>> have BlockBackends, thus an empty drive should be represented by a
>>> BlockBackend without any BDS tree attached to it. This is what this
>>> series does.
>>
>> Patches 1-16 and 18: Reviewed-by: Kevin Wolf <kwolf@redhat.com>
>>
>> I had comments for 17 and 19-21, and can't seem to find a base commit
>> that patch 22 applies cleanly to, so I'm stopping the review here,
>> waiting for another rebase or instructions how to apply the series.
> 
> 16a1b6e97c2a2919fd296db4bea2f9da2ad3cc4d was my base, if that was the
> question. ;-)

It can be applied to the upstream qemu very easily:
s/qmp_marshal_input_/qmp_marshal_/

> 
> Thanks for reviewing!
> 
> Max
>