From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754047AbbIWJen (ORCPT ); Wed, 23 Sep 2015 05:34:43 -0400 Received: from mx2.suse.de ([195.135.220.15]:36270 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753967AbbIWJeh (ORCPT ); Wed, 23 Sep 2015 05:34:37 -0400 Subject: Re: compaction.h: undefined CONFIG_ZONE_HIGHMEM_ To: Valentin Rothberg References: <20150923084320.GA16863@ubuntu-vm> Cc: rostedt@goodmis.org, mingo@redhat.com, linux-kernel@vger.kernel.org, akpm@linux-foundation.org, ziegler@cs.fau.de, Paul Bolle From: Vlastimil Babka Message-ID: <56027229.40206@suse.cz> Date: Wed, 23 Sep 2015 11:34:33 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <20150923084320.GA16863@ubuntu-vm> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/23/2015 10:43 AM, Valentin Rothberg wrote: > Hi Vlastimil, > > your commit 1434c81a47e3 ("mm, compaction: export tracepoints zone names > to userspace") has shown up in todays linux-next tree (i.e., 20150923) > adding the following lines of code: > > --- a/include/trace/events/compaction.h > +++ b/include/trace/events/compaction.h > @@ -18,6 +18,31 @@ > [...] > +#ifdef CONFIG_ZONE_HIGHMEM_ > +#define IFDEF_ZONE_HIGHMEM(X) X > +#else > +#define IFDEF_ZONE_HIGHMEM(X) > +#endif > > At the current state, the #ifdef block will not see a compiler since > CONFIG_ZONE_HIGHMEM_ is not defined anywhere. Ah damn, that's why a simple compile test won't catch this typo. > At first I thought it's a > typo as it ends with '_', but even ZONE_HIGHMEM isn't defined in > Kconfig. Is there a patch queued somewhere to fix the issue? It's actually just CONFIG_HIGHMEM (who needs consistency anyway?). Patch below. I didn't rename the IFDEF_ZONE_HIGHMEM as it's internal. When looking at zone_names I've noticed a CONFIG_ZONE_DEVICE. I assume compaction can't be run on this one so I'll ignore it. At worst the tracepoint string would be missing. > I detected the issue with undertaker-checkpatch from [1]. We run a > bot daily on linux-next to detect some Kconfig related issues and > bugs. Yeah I've heard about it on last year's Plumbers. Thanks for catching this! > Kind regards, Valentin > > [1] https://undertaker.cs.fau.de ------8<------ From: Vlastimil Babka Date: Wed, 23 Sep 2015 11:31:10 +0200 Subject: [PATCH] mm, compaction: export tracepoints zone names to userspace-fix Through undertaker-checkpatch it was reported that HighMem would be missing in the tracepoint output due to checking CONFIG_ZONE_HIGHMEM_ instead of CONFIG_HIGHMEM. Fix it. Reported-by: Valentin Rothberg Signed-off-by: Vlastimil Babka --- include/trace/events/compaction.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/trace/events/compaction.h b/include/trace/events/compaction.h index 5604994..c92d1e1 100644 --- a/include/trace/events/compaction.h +++ b/include/trace/events/compaction.h @@ -31,7 +31,7 @@ #define IFDEF_ZONE_DMA32(X) #endif -#ifdef CONFIG_ZONE_HIGHMEM_ +#ifdef CONFIG_HIGHMEM #define IFDEF_ZONE_HIGHMEM(X) X #else #define IFDEF_ZONE_HIGHMEM(X) -- 2.5.1