All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: "Daniel P. Berrange" <berrange@redhat.com>, qemu-devel@nongnu.org
Cc: John Snow <jsnow@redhat.com>, Laszlo Ersek <lersek@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2] docs: describe the QEMU build system structure / design
Date: Wed, 23 Sep 2015 12:06:54 +0200	[thread overview]
Message-ID: <560279BE.4030603@redhat.com> (raw)
In-Reply-To: <1443002356-22481-1-git-send-email-berrange@redhat.com>


A few nits that missed my first review:

On 23/09/2015 11:59, Daniel P. Berrange wrote:
> +A further complication for the system and userspace emulator binaries is
> +that two separate binaries need to be generated.

A further complication for the system emulator binaries (Windows does
not support userspace emulation) is that...

> There are no
> +corresponding $(QEMU_LIBS)/$(QEMU_LDFLAGS) variables, instead there are
> +a couple of more targeted variables.

The corresponding variable for linker flags is $(LIBS), but usually more
targeted variables are used instead.

> $(libs_softmmu) is used for
> +libraries that must be linked to system emulator targets, $(libs_tools)

$(LIBS_TOOLS)

> +is used for tools like qemu-img, qemu-nbd, etc and $(libs_qga) is used

$(LIBS_QGA)

> +for the QEMU guest agent. There is currently no variable for the
> +userspace emulator targets.

; they only use the generic $(LIBS) variable.

Paolo

  reply	other threads:[~2015-09-23 10:07 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-23  9:59 [Qemu-devel] [PATCH v2] docs: describe the QEMU build system structure / design Daniel P. Berrange
2015-09-23 10:06 ` Paolo Bonzini [this message]
2015-09-23 15:13 ` John Snow
2015-09-23 15:46 ` Laszlo Ersek
2015-09-23 15:47   ` Laszlo Ersek
2015-09-23 15:52   ` John Snow
2015-09-23 16:47     ` Eric Blake

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=560279BE.4030603@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=berrange@redhat.com \
    --cc=jsnow@redhat.com \
    --cc=lersek@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.