All of lore.kernel.org
 help / color / mirror / Atom feed
From: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: Intel Graphics Development <intel-gfx@lists.freedesktop.org>,
	Emil Renner Berthing <kernel@esmil.dk>
Subject: Re: [RFC PATCH] drm/i915: Consider SPLL as another shared pll.
Date: Wed, 23 Sep 2015 15:32:35 +0200	[thread overview]
Message-ID: <5602A9F3.5090602@linux.intel.com> (raw)
In-Reply-To: <20150923124209.GP3383@phenom.ffwll.local>

Op 23-09-15 om 14:42 schreef Daniel Vetter:
> On Wed, Sep 16, 2015 at 09:23:59AM +0200, Maarten Lankhorst wrote:
>> When diagnosing a unrelated bug for someone on irc, it would seem the hardware can
>> be brought up by the BIOS with the embedded displayport using the SPLL for spread spectrum.
>>
>> Right now this is not handled well in i915, and it calculates the crtc needs to
>> be reprogrammed on the first modeset without SSC, but  the SPLL itself was kept
>> active. Fix this by exposing SPLL as a shared pll that will not be returned
>> by intel_get_shared_dpll; you have to know it exists to use it. ;-)
>>
>> Cc: Emil Renner Berthing <kernel@esmil.dk>
>> Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
>> ---
>> RFC because I haven't tested it with VGA, but it seems to work according to fix
>> the problem mentioned above.
> lgtm and gets rid of some of the fdi vs. normal ddi special-casing, which
> is nice (since that's a problem for bxt dsi too). I'll pick this up as
> soon as you managed to run this on some hsw (since we inject a fake vga
> screen for igt tests you don't even need a real screen).
>
Emil, do you have a haswell and if so can you test with intel-gpu-tools? kms_pipe_crc_basic and see if it works correctly.
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2015-09-23 13:32 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-16  7:23 [RFC PATCH] drm/i915: Consider SPLL as another shared pll Maarten Lankhorst
2015-09-23 12:42 ` Daniel Vetter
2015-09-23 13:32   ` Maarten Lankhorst [this message]
2015-09-23 15:59     ` Emil Renner Berthing
2015-10-21  9:31 ` Daniel Vetter
2015-11-13  7:09   ` Jani Nikula

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5602A9F3.5090602@linux.intel.com \
    --to=maarten.lankhorst@linux.intel.com \
    --cc=daniel@ffwll.ch \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=kernel@esmil.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.