From: David Daney <ddaney@caviumnetworks.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: <linux-arm-kernel@lists.infradead.org>,
David Daney <ddaney.cavm@gmail.com>,
<linux-kernel@vger.kernel.org>, Will Deacon <will.deacon@arm.com>,
Marc Zyngier <marc.zyngier@arm.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Bjorn Helgaas <bhelgaas@google.com>, <linux-pci@vger.kernel.org>,
David Daney <david.daney@cavium.com>
Subject: Re: [PATCH] arm64/pci: Add quirks for Cavium Thunder PCI bridges.
Date: Wed, 23 Sep 2015 09:00:36 -0700 [thread overview]
Message-ID: <5602CCA4.8070606@caviumnetworks.com> (raw)
In-Reply-To: <1675889.xYIhzenZEC@wuerfel>
On 09/23/2015 12:51 AM, Arnd Bergmann wrote:
> On Tuesday 22 September 2015 17:09:56 David Daney wrote:
>> From: David Daney <david.daney@cavium.com>
>>
>> The Cavium ThunderX SoC needs a PCI quirk for its on-chip bridges.
>> Since it is arm64, create a new quirks.c file there to contain arm64
>> related quirks. Add the ThunderX bridge quirk, gated by a new config
>> variable, so that it can be disabled for kernels that aren't expected
>> to be used on ThunderX.
>>
>> Signed-off-by: David Daney <david.daney@cavium.com>
>> ---
>> arch/arm64/Kconfig | 11 +++++++++++
>> arch/arm64/kernel/Makefile | 2 +-
>> arch/arm64/kernel/quirks.c | 36 ++++++++++++++++++++++++++++++++++++
>> 3 files changed, 48 insertions(+), 1 deletion(-)
>> create mode 100644 arch/arm64/kernel/quirks.c
>>
>
> Looks reasonable to me. Just one question: Is the same bridge used
> on MIPS machines?
No. The MIPS64 based OCTEON family of SoCs does not contain
PCI-buses/config-space/bridges for on-chip hardware blocks. The on-chip
blocks in OCTEON are all platform devices. So, ...
> If so, maybe it should be moved to drivers/pci/quirks.c
> instead for better reuse.
The quirk is specific to some arm64 based SoCs, thus my idea to have
arch specific quirks.
David Daney
WARNING: multiple messages have this Message-ID (diff)
From: ddaney@caviumnetworks.com (David Daney)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm64/pci: Add quirks for Cavium Thunder PCI bridges.
Date: Wed, 23 Sep 2015 09:00:36 -0700 [thread overview]
Message-ID: <5602CCA4.8070606@caviumnetworks.com> (raw)
In-Reply-To: <1675889.xYIhzenZEC@wuerfel>
On 09/23/2015 12:51 AM, Arnd Bergmann wrote:
> On Tuesday 22 September 2015 17:09:56 David Daney wrote:
>> From: David Daney <david.daney@cavium.com>
>>
>> The Cavium ThunderX SoC needs a PCI quirk for its on-chip bridges.
>> Since it is arm64, create a new quirks.c file there to contain arm64
>> related quirks. Add the ThunderX bridge quirk, gated by a new config
>> variable, so that it can be disabled for kernels that aren't expected
>> to be used on ThunderX.
>>
>> Signed-off-by: David Daney <david.daney@cavium.com>
>> ---
>> arch/arm64/Kconfig | 11 +++++++++++
>> arch/arm64/kernel/Makefile | 2 +-
>> arch/arm64/kernel/quirks.c | 36 ++++++++++++++++++++++++++++++++++++
>> 3 files changed, 48 insertions(+), 1 deletion(-)
>> create mode 100644 arch/arm64/kernel/quirks.c
>>
>
> Looks reasonable to me. Just one question: Is the same bridge used
> on MIPS machines?
No. The MIPS64 based OCTEON family of SoCs does not contain
PCI-buses/config-space/bridges for on-chip hardware blocks. The on-chip
blocks in OCTEON are all platform devices. So, ...
> If so, maybe it should be moved to drivers/pci/quirks.c
> instead for better reuse.
The quirk is specific to some arm64 based SoCs, thus my idea to have
arch specific quirks.
David Daney
next prev parent reply other threads:[~2015-09-23 16:00 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-23 0:09 [PATCH] arm64/pci: Add quirks for Cavium Thunder PCI bridges David Daney
2015-09-23 0:09 ` David Daney
2015-09-23 7:51 ` Arnd Bergmann
2015-09-23 7:51 ` Arnd Bergmann
2015-09-23 16:00 ` David Daney [this message]
2015-09-23 16:00 ` David Daney
2015-09-23 19:36 ` Arnd Bergmann
2015-09-23 19:36 ` Arnd Bergmann
2015-09-23 18:40 ` Will Deacon
2015-09-23 18:40 ` Will Deacon
2015-09-23 18:48 ` David Daney
2015-09-23 18:48 ` David Daney
2015-11-24 21:52 ` Bjorn Helgaas
2015-11-24 21:52 ` Bjorn Helgaas
2015-11-24 22:26 ` David Daney
2015-11-24 22:26 ` David Daney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5602CCA4.8070606@caviumnetworks.com \
--to=ddaney@caviumnetworks.com \
--cc=arnd@arndb.de \
--cc=bhelgaas@google.com \
--cc=catalin.marinas@arm.com \
--cc=david.daney@cavium.com \
--cc=ddaney.cavm@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.