Re: [Qemu-devel] [PATCH v2 1/3] qapi: convert NumaOptions into a flat union

["Kővágó Zoltán" <dirty.ice.hu@gmail.com>]

2015-09-23 16:40 keltezéssel, Eric Blake írta:
> On 09/23/2015 08:27 AM, Kővágó, Zoltán wrote:
>> Changes the NumaOptions to flat union from a simple one.  This is
>> required by my later OptsVisitor patch to preserve backward
>> compatibility.
>>
>> Strictly speaking this would break QMP compatibility (as specified in
>> docs/qapi-code-gen.txt), but since no QMP command use this structure,
>> it's not an issue.  The -numa option syntax doesn't change.  There are
>> some changes in the C api, but this patch fixes them.
>>
>> Signed-off-by: Kővágó, Zoltán <DirtY.iCE.hu@gmail.com>
>> Reviewed-by: Eric Blake <eblake@redhat.com>
>>
>> ---
>>
>> Changes from v1:
>> * fixed documentation
>
> Since you're basing this on top of my pending series, why not take
> advantage of it...

Oh, so now that's possible.  I was too lazy to read the changes you have 
made to qapi...

Then I suppose I should do the same thing with NetLegacy.

>
>
>> +##
>> +# @NumaCommonOptions
>> +#
>> +# Common set of numa options.
>> +#
>> +# @type: NUMA command-line option type.
>> +#
>> +# Since: 2.5
>> +##
>> +{ 'struct': 'NumaCommonOptions',
>> +  'data': {
>> +    'type': 'NumaOptionType' } }
>
> ...by dropping this type, and instead...
>
>> +
>> +##
>> +# @NumaOptions
>> +#
>
> ...document @type here, and...
>
>> +# A discriminated record of NUMA options. (for OptsVisitor)
>> +#
>> +# Since 2.1
>> +##
>> +{ 'union': 'NumaOptions',
>> +  'base': 'NumaCommonOptions',
>
> ...write this as 'base': { 'type': 'NumaOptionType' },
>
>> +  'discriminator': 'type',
>> +  'data': {
>> +    'node': 'NumaNodeOptions' }}
>> +
>> +##
>>   # @HostMemPolicy
>>   #
>>   # Host memory policy types
>>
>