All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Daney <ddaney@caviumnetworks.com>
To: Will Deacon <will.deacon@arm.com>
Cc: David Daney <ddaney.cavm@gmail.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	Marc Zyngier <Marc.Zyngier@arm.com>,
	Catalin Marinas <Catalin.Marinas@arm.com>,
	Bjorn Helgaas <bhelgaas@google.com>,
	"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
	David Daney <david.daney@cavium.com>
Subject: Re: [PATCH] arm64/pci: Add quirks for Cavium Thunder PCI bridges.
Date: Wed, 23 Sep 2015 11:48:18 -0700	[thread overview]
Message-ID: <5602F3F2.2050100@caviumnetworks.com> (raw)
In-Reply-To: <20150923184005.GX7356@arm.com>

On 09/23/2015 11:40 AM, Will Deacon wrote:
> On Wed, Sep 23, 2015 at 01:09:56AM +0100, David Daney wrote:
>> From: David Daney <david.daney@cavium.com>
>>
>> The Cavium ThunderX SoC needs a PCI quirk for its on-chip bridges.
>> Since it is arm64, create a new quirks.c file there to contain arm64
>> related quirks.  Add the ThunderX bridge quirk, gated by a new config
>> variable, so that it can be disabled for kernels that aren't expected
>> to be used on ThunderX.
>>
>> Signed-off-by: David Daney <david.daney@cavium.com>
>> ---
>>   arch/arm64/Kconfig         | 11 +++++++++++
>>   arch/arm64/kernel/Makefile |  2 +-
>>   arch/arm64/kernel/quirks.c | 36 ++++++++++++++++++++++++++++++++++++
>>   3 files changed, 48 insertions(+), 1 deletion(-)
>>   create mode 100644 arch/arm64/kernel/quirks.c
>
> Why does this have to live in the arch/arm64/ directory? The quirks have
> nothing to do with the architecture code.
>

It doesn't have to live there.  It is something that will never be used 
for any other architecture.  So I thought we could do like 
arch/x86/kernel/quirks.c

I could move it to drivers/pci/quirks.c if people think that is a much 
better place for it.

David Daney

WARNING: multiple messages have this Message-ID (diff)
From: ddaney@caviumnetworks.com (David Daney)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm64/pci: Add quirks for Cavium Thunder PCI bridges.
Date: Wed, 23 Sep 2015 11:48:18 -0700	[thread overview]
Message-ID: <5602F3F2.2050100@caviumnetworks.com> (raw)
In-Reply-To: <20150923184005.GX7356@arm.com>

On 09/23/2015 11:40 AM, Will Deacon wrote:
> On Wed, Sep 23, 2015 at 01:09:56AM +0100, David Daney wrote:
>> From: David Daney <david.daney@cavium.com>
>>
>> The Cavium ThunderX SoC needs a PCI quirk for its on-chip bridges.
>> Since it is arm64, create a new quirks.c file there to contain arm64
>> related quirks.  Add the ThunderX bridge quirk, gated by a new config
>> variable, so that it can be disabled for kernels that aren't expected
>> to be used on ThunderX.
>>
>> Signed-off-by: David Daney <david.daney@cavium.com>
>> ---
>>   arch/arm64/Kconfig         | 11 +++++++++++
>>   arch/arm64/kernel/Makefile |  2 +-
>>   arch/arm64/kernel/quirks.c | 36 ++++++++++++++++++++++++++++++++++++
>>   3 files changed, 48 insertions(+), 1 deletion(-)
>>   create mode 100644 arch/arm64/kernel/quirks.c
>
> Why does this have to live in the arch/arm64/ directory? The quirks have
> nothing to do with the architecture code.
>

It doesn't have to live there.  It is something that will never be used 
for any other architecture.  So I thought we could do like 
arch/x86/kernel/quirks.c

I could move it to drivers/pci/quirks.c if people think that is a much 
better place for it.

David Daney

  reply	other threads:[~2015-09-23 18:48 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-23  0:09 [PATCH] arm64/pci: Add quirks for Cavium Thunder PCI bridges David Daney
2015-09-23  0:09 ` David Daney
2015-09-23  7:51 ` Arnd Bergmann
2015-09-23  7:51   ` Arnd Bergmann
2015-09-23 16:00   ` David Daney
2015-09-23 16:00     ` David Daney
2015-09-23 19:36     ` Arnd Bergmann
2015-09-23 19:36       ` Arnd Bergmann
2015-09-23 18:40 ` Will Deacon
2015-09-23 18:40   ` Will Deacon
2015-09-23 18:48   ` David Daney [this message]
2015-09-23 18:48     ` David Daney
2015-11-24 21:52 ` Bjorn Helgaas
2015-11-24 21:52   ` Bjorn Helgaas
2015-11-24 22:26   ` David Daney
2015-11-24 22:26     ` David Daney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5602F3F2.2050100@caviumnetworks.com \
    --to=ddaney@caviumnetworks.com \
    --cc=Catalin.Marinas@arm.com \
    --cc=Marc.Zyngier@arm.com \
    --cc=bhelgaas@google.com \
    --cc=david.daney@cavium.com \
    --cc=ddaney.cavm@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=will.deacon@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.