Re: [PATCH 0/5] Add ASoC support for AMD APUs [v3]

["Christian König" <deathsimple@vodafone.de>]

Only briefly skimmed over the patches, but the approach sounds sane to me.

So the set is Acked-by: Christian König <christian.koenig@amd.com>

Regards,
Christian.

On 23.09.2015 19:02, Alex Deucher wrote:
> This patch set implements support for i2s audio and new AMD GPUs.
> The i2s codec is fed by a DMA engine on the GPU.  To handle this
> we create mfd cells which we hang the i2s codec and DMA engine on.
> Because of this, this patch set covers two subsystems: drm and alsa.
> The drm patches add support for the ACP hw block which provides the
> DMA engine for the i2s codec.  The alsa patches add the ASoC driver
> for the i2s codec.  Since the alsa changes depend on the drm changes
> in this patch set as well as some other drm changes queued for 4.3,
> I'd like to take the alsa patches in via the drm tree.
>
> V2 changes:
> - Use the MFD subsystem rather than adding our own bus
> - Squash all sub-feature patches together
> - fix comments mentioned in previous review
>
> V3 changes:
> - Update the designware driver to handle slave mode, amd specific
>    features
> - Use the designware driver directly for i2s
> - Move the DMA handling from the GPU driver into the AMD ASoC
>    driver
> - Change the license on the ASoC driver to GPL
>
> Patch 4 adds the register headers for the ACP block which is a
> pretty big patch so I've excluded it from email.  The entire patch
> set can be viewed here:
> http://cgit.freedesktop.org/~agd5f/linux/log/?h=acp-upstream3
>
> Thanks,
>
> Alex
>
> Maruthi Bayyavarapu (1):
>    drm/amd: add ACP driver support
>
> Maruthi Srinivas Bayyavarapu (4):
>    ASoC : dwc : support dw i2s in slave mode
>    ASoC : dwc : support dw i2s in AMD platform
>    ASoC : AMD : add ACP 2.2 register headers
>    ASoC: AMD: add AMD ASoC ACP-I2S driver
>
>   drivers/gpu/drm/Kconfig                      |    2 +
>   drivers/gpu/drm/amd/acp/Kconfig              |   10 +
>   drivers/gpu/drm/amd/acp/Makefile             |    9 +
>   drivers/gpu/drm/amd/acp/acp_hw.c             |  127 ++
>   drivers/gpu/drm/amd/acp/include/acp_gfx_if.h |   49 +
>   drivers/gpu/drm/amd/amdgpu/Makefile          |   13 +-
>   drivers/gpu/drm/amd/amdgpu/amdgpu.h          |   12 +
>   drivers/gpu/drm/amd/amdgpu/amdgpu_acp.c      |  269 +++
>   drivers/gpu/drm/amd/amdgpu/amdgpu_acp.h      |   41 +
>   drivers/gpu/drm/amd/amdgpu/vi.c              |   12 +
>   drivers/gpu/drm/amd/include/amd_shared.h     |    1 +
>   include/linux/mfd/amd_acp.h                  |   43 +
>   include/sound/designware_i2s.h               |    4 +
>   sound/soc/Kconfig                            |    1 +
>   sound/soc/Makefile                           |    1 +
>   sound/soc/amd/Kconfig                        |    4 +
>   sound/soc/amd/Makefile                       |    3 +
>   sound/soc/amd/acp-pcm-dma.c                  |  518 ++++++
>   sound/soc/amd/acp.c                          |  736 +++++++++
>   sound/soc/amd/acp.h                          |  147 ++
>   sound/soc/amd/include/acp_2_2_d.h            |  609 +++++++
>   sound/soc/amd/include/acp_2_2_enum.h         | 1068 ++++++++++++
>   sound/soc/amd/include/acp_2_2_sh_mask.h      | 2292 ++++++++++++++++++++++++++
>   sound/soc/dwc/designware_i2s.c               |  270 +--
>   24 files changed, 6141 insertions(+), 100 deletions(-)
>   create mode 100644 drivers/gpu/drm/amd/acp/Kconfig
>   create mode 100644 drivers/gpu/drm/amd/acp/Makefile
>   create mode 100644 drivers/gpu/drm/amd/acp/acp_hw.c
>   create mode 100644 drivers/gpu/drm/amd/acp/include/acp_gfx_if.h
>   create mode 100644 drivers/gpu/drm/amd/amdgpu/amdgpu_acp.c
>   create mode 100644 drivers/gpu/drm/amd/amdgpu/amdgpu_acp.h
>   create mode 100644 include/linux/mfd/amd_acp.h
>   create mode 100644 sound/soc/amd/Kconfig
>   create mode 100644 sound/soc/amd/Makefile
>   create mode 100644 sound/soc/amd/acp-pcm-dma.c
>   create mode 100644 sound/soc/amd/acp.c
>   create mode 100644 sound/soc/amd/acp.h
>   create mode 100644 sound/soc/amd/include/acp_2_2_d.h
>   create mode 100644 sound/soc/amd/include/acp_2_2_enum.h
>   create mode 100644 sound/soc/amd/include/acp_2_2_sh_mask.h
>

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel