All of lore.kernel.org
 help / color / mirror / Atom feed
From: nm@ti.com (Nishanth Menon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/3] Documentation: dt: keystone: provide SoC specific compatible flags
Date: Wed, 23 Sep 2015 14:15:09 -0500	[thread overview]
Message-ID: <5602FA3D.9050702@ti.com> (raw)
In-Reply-To: <5602E9F3.7020102@ti.com>

On 09/23/2015 01:05 PM, Murali Karicheri wrote:
> On 09/22/2015 12:08 PM, Nishanth Menon wrote:
[...]

>> diff --git
>> a/Documentation/devicetree/bindings/arm/keystone/keystone.txt
>> b/Documentation/devicetree/bindings/arm/keystone/keystone.txt
>> index 59d7a46f85eb..800d2d02e27b 100644
>> --- a/Documentation/devicetree/bindings/arm/keystone/keystone.txt
>> +++ b/Documentation/devicetree/bindings/arm/keystone/keystone.txt
>> @@ -9,12 +9,26 @@ Required properties:
>>      the form "ti,keystone-*". Generic devices like gic, arch_timers,
>> ns16550
>>      type UART should use the specified compatible for those devices.
>>
>> +SoC families:
>> +
>> +- Keystone 2 generic SoC:
>> +   compatible = "ti,keystone"
>> +
>> +SoCs:
>> +
>> +- Keystone 2 Hawking/Kepler
>> +   compatible = ti,k2hk", "ti,keystone"
>> +- Keystone 2 Lamarr
>> +   compatible = ti,k2l", "ti,keystone"
>> +- Keystone 2 Edison
>> +   compatible = ti,k2e", "ti,keystone"
>> +
>>   Boards:
>>   -  Keystone 2 Hawking/Kepler EVM
>> -   compatible = "ti,k2hk-evm","ti,keystone"
>> +   compatible = "ti,k2hk-evm", "ti,k2hk", "ti,keystone"
>>
>>   -  Keystone 2 Lamarr EVM
>> -   compatible = "ti,k2l-evm","ti,keystone"
>> +   compatible = "ti,k2l-evm", "ti, k2l", "ti,keystone"
>>
>>   -  Keystone 2 Edison EVM
>> -   compatible = "ti,k2e-evm","ti,keystone"
>> +   compatible = "ti,k2e-evm", "ti,k2e", "ti,keystone"
>>
> DTS takes care of the difference in the hardware and If there SoC
> specific customization required outside this, then it is best to include
> this as part of that change. In the past, I believe we didn't do it due
> to the same reason as above.

Right now, they all claim to be the same keystone SoC -> which is
inaccurate at the very least, and downright wrong IMHO since k2e/hk and
l are different SoCs - even though they belong to keystone family, they
are as similar as OMAP4 is to OMAP5 is to DRA7. This is similar to how
various other SoCs distinguish between SoCs as well.

-- 
Regards,
Nishanth Menon

WARNING: multiple messages have this Message-ID (diff)
From: Nishanth Menon <nm-l0cyMroinI0@public.gmane.org>
To: Murali Karicheri <m-karicheri2-l0cyMroinI0@public.gmane.org>,
	Nishanth Menon <nm-l0cyMroinI0@public.gmane.org>,
	Santosh Shilimkar
	<ssantosh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH 1/3] Documentation: dt: keystone: provide SoC specific compatible flags
Date: Wed, 23 Sep 2015 14:15:09 -0500	[thread overview]
Message-ID: <5602FA3D.9050702@ti.com> (raw)
In-Reply-To: <5602E9F3.7020102-l0cyMroinI0@public.gmane.org>

On 09/23/2015 01:05 PM, Murali Karicheri wrote:
> On 09/22/2015 12:08 PM, Nishanth Menon wrote:
[...]

>> diff --git
>> a/Documentation/devicetree/bindings/arm/keystone/keystone.txt
>> b/Documentation/devicetree/bindings/arm/keystone/keystone.txt
>> index 59d7a46f85eb..800d2d02e27b 100644
>> --- a/Documentation/devicetree/bindings/arm/keystone/keystone.txt
>> +++ b/Documentation/devicetree/bindings/arm/keystone/keystone.txt
>> @@ -9,12 +9,26 @@ Required properties:
>>      the form "ti,keystone-*". Generic devices like gic, arch_timers,
>> ns16550
>>      type UART should use the specified compatible for those devices.
>>
>> +SoC families:
>> +
>> +- Keystone 2 generic SoC:
>> +   compatible = "ti,keystone"
>> +
>> +SoCs:
>> +
>> +- Keystone 2 Hawking/Kepler
>> +   compatible = ti,k2hk", "ti,keystone"
>> +- Keystone 2 Lamarr
>> +   compatible = ti,k2l", "ti,keystone"
>> +- Keystone 2 Edison
>> +   compatible = ti,k2e", "ti,keystone"
>> +
>>   Boards:
>>   -  Keystone 2 Hawking/Kepler EVM
>> -   compatible = "ti,k2hk-evm","ti,keystone"
>> +   compatible = "ti,k2hk-evm", "ti,k2hk", "ti,keystone"
>>
>>   -  Keystone 2 Lamarr EVM
>> -   compatible = "ti,k2l-evm","ti,keystone"
>> +   compatible = "ti,k2l-evm", "ti, k2l", "ti,keystone"
>>
>>   -  Keystone 2 Edison EVM
>> -   compatible = "ti,k2e-evm","ti,keystone"
>> +   compatible = "ti,k2e-evm", "ti,k2e", "ti,keystone"
>>
> DTS takes care of the difference in the hardware and If there SoC
> specific customization required outside this, then it is best to include
> this as part of that change. In the past, I believe we didn't do it due
> to the same reason as above.

Right now, they all claim to be the same keystone SoC -> which is
inaccurate at the very least, and downright wrong IMHO since k2e/hk and
l are different SoCs - even though they belong to keystone family, they
are as similar as OMAP4 is to OMAP5 is to DRA7. This is similar to how
various other SoCs distinguish between SoCs as well.

-- 
Regards,
Nishanth Menon
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: Nishanth Menon <nm@ti.com>
To: Murali Karicheri <m-karicheri2@ti.com>,
	Nishanth Menon <nm@ti.com>,
	Santosh Shilimkar <ssantosh@kernel.org>
Cc: <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 1/3] Documentation: dt: keystone: provide SoC specific compatible flags
Date: Wed, 23 Sep 2015 14:15:09 -0500	[thread overview]
Message-ID: <5602FA3D.9050702@ti.com> (raw)
In-Reply-To: <5602E9F3.7020102@ti.com>

On 09/23/2015 01:05 PM, Murali Karicheri wrote:
> On 09/22/2015 12:08 PM, Nishanth Menon wrote:
[...]

>> diff --git
>> a/Documentation/devicetree/bindings/arm/keystone/keystone.txt
>> b/Documentation/devicetree/bindings/arm/keystone/keystone.txt
>> index 59d7a46f85eb..800d2d02e27b 100644
>> --- a/Documentation/devicetree/bindings/arm/keystone/keystone.txt
>> +++ b/Documentation/devicetree/bindings/arm/keystone/keystone.txt
>> @@ -9,12 +9,26 @@ Required properties:
>>      the form "ti,keystone-*". Generic devices like gic, arch_timers,
>> ns16550
>>      type UART should use the specified compatible for those devices.
>>
>> +SoC families:
>> +
>> +- Keystone 2 generic SoC:
>> +   compatible = "ti,keystone"
>> +
>> +SoCs:
>> +
>> +- Keystone 2 Hawking/Kepler
>> +   compatible = ti,k2hk", "ti,keystone"
>> +- Keystone 2 Lamarr
>> +   compatible = ti,k2l", "ti,keystone"
>> +- Keystone 2 Edison
>> +   compatible = ti,k2e", "ti,keystone"
>> +
>>   Boards:
>>   -  Keystone 2 Hawking/Kepler EVM
>> -   compatible = "ti,k2hk-evm","ti,keystone"
>> +   compatible = "ti,k2hk-evm", "ti,k2hk", "ti,keystone"
>>
>>   -  Keystone 2 Lamarr EVM
>> -   compatible = "ti,k2l-evm","ti,keystone"
>> +   compatible = "ti,k2l-evm", "ti, k2l", "ti,keystone"
>>
>>   -  Keystone 2 Edison EVM
>> -   compatible = "ti,k2e-evm","ti,keystone"
>> +   compatible = "ti,k2e-evm", "ti,k2e", "ti,keystone"
>>
> DTS takes care of the difference in the hardware and If there SoC
> specific customization required outside this, then it is best to include
> this as part of that change. In the past, I believe we didn't do it due
> to the same reason as above.

Right now, they all claim to be the same keystone SoC -> which is
inaccurate at the very least, and downright wrong IMHO since k2e/hk and
l are different SoCs - even though they belong to keystone family, they
are as similar as OMAP4 is to OMAP5 is to DRA7. This is similar to how
various other SoCs distinguish between SoCs as well.

-- 
Regards,
Nishanth Menon

  reply	other threads:[~2015-09-23 19:15 UTC|newest]

Thread overview: 70+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-22 16:08 [PATCH 0/3] ARM: dts/keystone: Introduce SoC specific compatible matches Nishanth Menon
2015-09-22 16:08 ` Nishanth Menon
2015-09-22 16:08 ` Nishanth Menon
2015-09-22 16:08 ` [PATCH 1/3] Documentation: dt: keystone: provide SoC specific compatible flags Nishanth Menon
2015-09-22 16:08   ` Nishanth Menon
2015-09-22 16:08   ` Nishanth Menon
2015-09-23 18:05   ` Murali Karicheri
2015-09-23 18:05     ` Murali Karicheri
2015-09-23 18:05     ` Murali Karicheri
2015-09-23 19:15     ` Nishanth Menon [this message]
2015-09-23 19:15       ` Nishanth Menon
2015-09-23 19:15       ` Nishanth Menon
2015-09-23 18:19   ` santosh shilimkar
2015-09-23 18:19     ` santosh shilimkar
2015-09-23 18:19     ` santosh shilimkar
2015-09-24 14:05     ` Murali Karicheri
2015-09-24 14:05       ` Murali Karicheri
2015-09-24 14:05       ` Murali Karicheri
2015-09-24 14:20       ` Nishanth Menon
2015-09-24 14:20         ` Nishanth Menon
2015-09-24 14:20         ` Nishanth Menon
2015-09-24 15:54         ` Murali Karicheri
2015-09-24 15:54           ` Murali Karicheri
2015-09-24 15:54           ` Murali Karicheri
2015-09-25 14:50           ` Nishanth Menon
2015-09-25 14:50             ` Nishanth Menon
2015-09-25 14:50             ` Nishanth Menon
2015-09-25 15:18             ` santosh shilimkar
2015-09-25 15:18               ` santosh shilimkar
2015-09-25 16:01               ` Nishanth Menon
2015-09-25 16:01                 ` Nishanth Menon
2015-09-25 16:01                 ` Nishanth Menon
2015-09-25 16:15                 ` santosh shilimkar
2015-09-25 16:15                   ` santosh shilimkar
2015-09-25 16:15                   ` santosh shilimkar
2015-09-25 17:38                   ` Nishanth Menon
2015-09-25 17:38                     ` Nishanth Menon
2015-09-25 17:38                     ` Nishanth Menon
2015-10-02 16:09                     ` santosh shilimkar
2015-10-02 16:09                       ` santosh shilimkar
2015-10-03 23:44                       ` Nishanth Menon
2015-10-03 23:44                         ` Nishanth Menon
2015-10-03 23:44                         ` Nishanth Menon
2015-10-04  0:16                         ` santosh.shilimkar at oracle.com
2015-10-04  0:16                           ` santosh.shilimkar
2015-10-04  0:16                           ` santosh.shilimkar-QHcLZuEGTsvQT0dZR+AlfA
2015-09-30 14:31                 ` Murali Karicheri
2015-09-30 14:31                   ` Murali Karicheri
2015-09-30 14:31                   ` Murali Karicheri
2015-09-22 16:08 ` [PATCH 2/3] ARM: keystone: Update compatible to have SoC specific matches Nishanth Menon
2015-09-22 16:08   ` Nishanth Menon
2015-09-22 16:08   ` Nishanth Menon
2015-09-22 16:08 ` [PATCH 3/3] ARM: dts: keystone: Update SoC specific compatible flags Nishanth Menon
2015-09-22 16:08   ` Nishanth Menon
2015-09-22 16:08   ` Nishanth Menon
2015-10-03 23:38 ` [PATCH V2 0/3] ARM: dts/keystone: Introduce SoC specific compatible matches Nishanth Menon
2015-10-03 23:38   ` Nishanth Menon
2015-10-03 23:38   ` Nishanth Menon
2015-10-03 23:38   ` [PATCH V2 1/3] Documentation: dt: keystone: provide SoC specific compatible flags Nishanth Menon
2015-10-03 23:38     ` Nishanth Menon
2015-10-03 23:38     ` Nishanth Menon
2015-10-03 23:38   ` [PATCH V2 2/3] ARM: keystone: Update compatible to have SoC specific matches Nishanth Menon
2015-10-03 23:38     ` Nishanth Menon
2015-10-03 23:38     ` Nishanth Menon
2015-10-03 23:38   ` [PATCH V2 3/3] ARM: dts: keystone: Update SoC specific compatible flags Nishanth Menon
2015-10-03 23:38     ` Nishanth Menon
2015-10-03 23:38     ` Nishanth Menon
2015-10-04  0:13   ` [PATCH V2 0/3] ARM: dts/keystone: Introduce SoC specific compatible matches santosh.shilimkar at oracle.com
2015-10-04  0:13     ` santosh.shilimkar
2015-10-04  0:13     ` santosh.shilimkar-QHcLZuEGTsvQT0dZR+AlfA

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5602FA3D.9050702@ti.com \
    --to=nm@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.