From mboxrd@z Thu Jan 1 00:00:00 1970 From: nm@ti.com (Nishanth Menon) Date: Wed, 23 Sep 2015 14:15:09 -0500 Subject: [PATCH 1/3] Documentation: dt: keystone: provide SoC specific compatible flags In-Reply-To: <5602E9F3.7020102@ti.com> References: <1442938118-4718-1-git-send-email-nm@ti.com> <1442938118-4718-2-git-send-email-nm@ti.com> <5602E9F3.7020102@ti.com> Message-ID: <5602FA3D.9050702@ti.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 09/23/2015 01:05 PM, Murali Karicheri wrote: > On 09/22/2015 12:08 PM, Nishanth Menon wrote: [...] >> diff --git >> a/Documentation/devicetree/bindings/arm/keystone/keystone.txt >> b/Documentation/devicetree/bindings/arm/keystone/keystone.txt >> index 59d7a46f85eb..800d2d02e27b 100644 >> --- a/Documentation/devicetree/bindings/arm/keystone/keystone.txt >> +++ b/Documentation/devicetree/bindings/arm/keystone/keystone.txt >> @@ -9,12 +9,26 @@ Required properties: >> the form "ti,keystone-*". Generic devices like gic, arch_timers, >> ns16550 >> type UART should use the specified compatible for those devices. >> >> +SoC families: >> + >> +- Keystone 2 generic SoC: >> + compatible = "ti,keystone" >> + >> +SoCs: >> + >> +- Keystone 2 Hawking/Kepler >> + compatible = ti,k2hk", "ti,keystone" >> +- Keystone 2 Lamarr >> + compatible = ti,k2l", "ti,keystone" >> +- Keystone 2 Edison >> + compatible = ti,k2e", "ti,keystone" >> + >> Boards: >> - Keystone 2 Hawking/Kepler EVM >> - compatible = "ti,k2hk-evm","ti,keystone" >> + compatible = "ti,k2hk-evm", "ti,k2hk", "ti,keystone" >> >> - Keystone 2 Lamarr EVM >> - compatible = "ti,k2l-evm","ti,keystone" >> + compatible = "ti,k2l-evm", "ti, k2l", "ti,keystone" >> >> - Keystone 2 Edison EVM >> - compatible = "ti,k2e-evm","ti,keystone" >> + compatible = "ti,k2e-evm", "ti,k2e", "ti,keystone" >> > DTS takes care of the difference in the hardware and If there SoC > specific customization required outside this, then it is best to include > this as part of that change. In the past, I believe we didn't do it due > to the same reason as above. Right now, they all claim to be the same keystone SoC -> which is inaccurate at the very least, and downright wrong IMHO since k2e/hk and l are different SoCs - even though they belong to keystone family, they are as similar as OMAP4 is to OMAP5 is to DRA7. This is similar to how various other SoCs distinguish between SoCs as well. -- Regards, Nishanth Menon From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nishanth Menon Subject: Re: [PATCH 1/3] Documentation: dt: keystone: provide SoC specific compatible flags Date: Wed, 23 Sep 2015 14:15:09 -0500 Message-ID: <5602FA3D.9050702@ti.com> References: <1442938118-4718-1-git-send-email-nm@ti.com> <1442938118-4718-2-git-send-email-nm@ti.com> <5602E9F3.7020102@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <5602E9F3.7020102-l0cyMroinI0@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Murali Karicheri , Nishanth Menon , Santosh Shilimkar Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: devicetree@vger.kernel.org On 09/23/2015 01:05 PM, Murali Karicheri wrote: > On 09/22/2015 12:08 PM, Nishanth Menon wrote: [...] >> diff --git >> a/Documentation/devicetree/bindings/arm/keystone/keystone.txt >> b/Documentation/devicetree/bindings/arm/keystone/keystone.txt >> index 59d7a46f85eb..800d2d02e27b 100644 >> --- a/Documentation/devicetree/bindings/arm/keystone/keystone.txt >> +++ b/Documentation/devicetree/bindings/arm/keystone/keystone.txt >> @@ -9,12 +9,26 @@ Required properties: >> the form "ti,keystone-*". Generic devices like gic, arch_timers, >> ns16550 >> type UART should use the specified compatible for those devices. >> >> +SoC families: >> + >> +- Keystone 2 generic SoC: >> + compatible = "ti,keystone" >> + >> +SoCs: >> + >> +- Keystone 2 Hawking/Kepler >> + compatible = ti,k2hk", "ti,keystone" >> +- Keystone 2 Lamarr >> + compatible = ti,k2l", "ti,keystone" >> +- Keystone 2 Edison >> + compatible = ti,k2e", "ti,keystone" >> + >> Boards: >> - Keystone 2 Hawking/Kepler EVM >> - compatible = "ti,k2hk-evm","ti,keystone" >> + compatible = "ti,k2hk-evm", "ti,k2hk", "ti,keystone" >> >> - Keystone 2 Lamarr EVM >> - compatible = "ti,k2l-evm","ti,keystone" >> + compatible = "ti,k2l-evm", "ti, k2l", "ti,keystone" >> >> - Keystone 2 Edison EVM >> - compatible = "ti,k2e-evm","ti,keystone" >> + compatible = "ti,k2e-evm", "ti,k2e", "ti,keystone" >> > DTS takes care of the difference in the hardware and If there SoC > specific customization required outside this, then it is best to include > this as part of that change. In the past, I believe we didn't do it due > to the same reason as above. Right now, they all claim to be the same keystone SoC -> which is inaccurate at the very least, and downright wrong IMHO since k2e/hk and l are different SoCs - even though they belong to keystone family, they are as similar as OMAP4 is to OMAP5 is to DRA7. This is similar to how various other SoCs distinguish between SoCs as well. -- Regards, Nishanth Menon -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754817AbbIWTQK (ORCPT ); Wed, 23 Sep 2015 15:16:10 -0400 Received: from comal.ext.ti.com ([198.47.26.152]:49646 "EHLO comal.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753293AbbIWTQI (ORCPT ); Wed, 23 Sep 2015 15:16:08 -0400 Message-ID: <5602FA3D.9050702@ti.com> Date: Wed, 23 Sep 2015 14:15:09 -0500 From: Nishanth Menon User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.8.0 MIME-Version: 1.0 To: Murali Karicheri , Nishanth Menon , Santosh Shilimkar CC: , , Subject: Re: [PATCH 1/3] Documentation: dt: keystone: provide SoC specific compatible flags References: <1442938118-4718-1-git-send-email-nm@ti.com> <1442938118-4718-2-git-send-email-nm@ti.com> <5602E9F3.7020102@ti.com> In-Reply-To: <5602E9F3.7020102@ti.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [172.22.187.243] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/23/2015 01:05 PM, Murali Karicheri wrote: > On 09/22/2015 12:08 PM, Nishanth Menon wrote: [...] >> diff --git >> a/Documentation/devicetree/bindings/arm/keystone/keystone.txt >> b/Documentation/devicetree/bindings/arm/keystone/keystone.txt >> index 59d7a46f85eb..800d2d02e27b 100644 >> --- a/Documentation/devicetree/bindings/arm/keystone/keystone.txt >> +++ b/Documentation/devicetree/bindings/arm/keystone/keystone.txt >> @@ -9,12 +9,26 @@ Required properties: >> the form "ti,keystone-*". Generic devices like gic, arch_timers, >> ns16550 >> type UART should use the specified compatible for those devices. >> >> +SoC families: >> + >> +- Keystone 2 generic SoC: >> + compatible = "ti,keystone" >> + >> +SoCs: >> + >> +- Keystone 2 Hawking/Kepler >> + compatible = ti,k2hk", "ti,keystone" >> +- Keystone 2 Lamarr >> + compatible = ti,k2l", "ti,keystone" >> +- Keystone 2 Edison >> + compatible = ti,k2e", "ti,keystone" >> + >> Boards: >> - Keystone 2 Hawking/Kepler EVM >> - compatible = "ti,k2hk-evm","ti,keystone" >> + compatible = "ti,k2hk-evm", "ti,k2hk", "ti,keystone" >> >> - Keystone 2 Lamarr EVM >> - compatible = "ti,k2l-evm","ti,keystone" >> + compatible = "ti,k2l-evm", "ti, k2l", "ti,keystone" >> >> - Keystone 2 Edison EVM >> - compatible = "ti,k2e-evm","ti,keystone" >> + compatible = "ti,k2e-evm", "ti,k2e", "ti,keystone" >> > DTS takes care of the difference in the hardware and If there SoC > specific customization required outside this, then it is best to include > this as part of that change. In the past, I believe we didn't do it due > to the same reason as above. Right now, they all claim to be the same keystone SoC -> which is inaccurate at the very least, and downright wrong IMHO since k2e/hk and l are different SoCs - even though they belong to keystone family, they are as similar as OMAP4 is to OMAP5 is to DRA7. This is similar to how various other SoCs distinguish between SoCs as well. -- Regards, Nishanth Menon