From: Alexei Starovoitov <ast@plumgrid.com>
To: Daniel Borkmann <daniel@iogearbox.net>, davem@davemloft.net
Cc: jhs@mojatatu.com, netdev@vger.kernel.org
Subject: Re: [PATCH net-next 2/3] cls_bpf: make binding to classid optional
Date: Wed, 23 Sep 2015 13:53:29 -0700 [thread overview]
Message-ID: <56031149.50003@plumgrid.com> (raw)
In-Reply-To: <564eafb6e648e41ad57f5d36139d667745478366.1443037353.git.daniel@iogearbox.net>
On 9/23/15 12:56 PM, Daniel Borkmann wrote:
> The binding to a particular classid was so far always mandatory for
> cls_bpf, but it doesn't need to be. Therefore, lift this restriction
> as similarly done in other classifiers.
>
> Only a couple of qdiscs make use of class from the tcf_result, others
> don't strictly care, so let the user choose his needs (those that read
> out class can handle situations where it could be NULL).
>
> An explicit check for tcf_unbind_filter() is also not needed here, as
> the previous r->class was 0, so the xchg() will return that and
> therefore a callback to the qdisc's unbind_tcf() is skipped.
>
> Signed-off-by: Daniel Borkmann<daniel@iogearbox.net>
Acked-by: Alexei Starovoitov <ast@plumgrid.com>
next prev parent reply other threads:[~2015-09-23 20:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-23 19:56 [PATCH net-next 0/3] Minor cls_bpf updates Daniel Borkmann
2015-09-23 19:56 ` [PATCH net-next 1/3] cls_bpf: also dump TCA_BPF_FLAGS Daniel Borkmann
2015-09-23 20:52 ` Alexei Starovoitov
2015-09-23 19:56 ` [PATCH net-next 2/3] cls_bpf: make binding to classid optional Daniel Borkmann
2015-09-23 20:53 ` Alexei Starovoitov [this message]
2015-09-23 19:56 ` [PATCH net-next 3/3] cls_bpf: further limit exec opcodes subset Daniel Borkmann
2015-09-23 20:54 ` Alexei Starovoitov
2015-09-23 21:29 ` [PATCH net-next 0/3] Minor cls_bpf updates David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56031149.50003@plumgrid.com \
--to=ast@plumgrid.com \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=jhs@mojatatu.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.